sign fix in decimal1()

mknos · web-flow · commit cdb391cd5247 · 2025-01-23T09:47:47.000+08:00
* Use the correct unpack format "c" for signed char
* Add a comment to clarify why some ascii character names have an embedded space
diff --git a/bin/od b/bin/od
@@ -44,6 +44,7 @@ my %charescs = (
     92 => ' \\\\',
 );
 
+# embedded space allows formatting without sprintf
 my %charname = (
     0  => 'nul',
     1  => 'soh',
@@ -295,7 +296,7 @@ sub octal1 {
 }
 
 sub decimal1 {
-    @arr = unpack 'C*', $data;
+    @arr = unpack 'c*', $data;
     $strfmt = '%4d ' x (scalar @arr);
 }
 

Original file line number	Diff line number	Diff line change
`@@ -44,6 +44,7 @@ my %charescs = (`
`44`	`44`	`92 => ' \\\\',`
`45`	`45`	`);`
`46`	`46`
	`47`	`+# embedded space allows formatting without sprintf`
`47`	`48`	`my %charname = (`
`48`	`49`	`0 => 'nul',`
`49`	`50`	`1 => 'soh',`
`@@ -295,7 +296,7 @@ sub octal1 {`
`295`	`296`	`}`
`296`	`297`
`297`	`298`	`sub decimal1 {`
`298`		`- @arr = unpack 'C*', $data;`
	`299`	`+ @arr = unpack 'c*', $data;`
`299`	`300`	`$strfmt = '%4d ' x (scalar @arr);`
`300`	`301`	`}`
`301`	`302`