join: confusing declarations (briandfoy#953)

* Simplify code in get_opt() to make it clearer to reader that there is only one function parameter, i.e. $arg
* Update 2 loops using until-not pattern instead of regular while pattern; found by perlcritic

%perl cat names # regression test
1 BoB
2 Budii
3 B-LITE
10 BLINK
%perl cat prices
1 $500
2 $30
3 50c
6 $2
%perl join names prices
1 BoB $500
2 Budii $30
3 B-LITE 50c

Author: mknos

bin/join

@@ -132,12 +132,12 @@ while (@buf1 && @buf2) {
 if ($unpairables[0] && @buf1) {
   do{
     print_joined_lines(shift @buf1, [])
-  } until !get_a_line(\@buf1, $fh1);
+  } while get_a_line(\@buf1, $fh1);
 }
 if ($unpairables[1] && @buf2) {
   do{
     print_joined_lines([], shift @buf2)
-  } until !get_a_line(\@buf2, $fh2);
+  } while get_a_line(\@buf2, $fh2);
 }
 
 unless (close $fh1) {
@@ -195,8 +195,9 @@ sub print_joined_lines {
 # OPTIONS STUFF BELOW #
 #######################
 sub get_arg {
-  # $_ contains current arg
-  my ($arg,$opt) = shift;
+  # $_ contains VAL in -oVAL
+  my $arg = shift;
+  my $opt;
   if    (length) { $opt = $_ }
   elsif (@ARGV)  { $opt = shift @ARGV }
   else {