Support enabling PHP extensions when multiple extension versions are installed

Author: mlocati

PhpManager/public/Disable-PhpExtension.ps1

@@ -53,25 +53,23 @@ function Disable-PhpExtension() {
         $extensionsToDisable = @()
         foreach ($wantedExtension in $Extension) {
             $foundExtensions = @($allExtensions | Where-Object { $_.Name -like $wantedExtension })
-            if ($foundExtensions.Count -ne 1) {
+            if ($foundExtensions.Count -eq 0) {
                 $foundExtensions = @($allExtensions | Where-Object { $_.Handle -like $wantedExtension })
                 if ($foundExtensions.Count -eq 0) {
                     throw "Unable to find a locally available extension with name (or handle) `"$wantedExtension`": use the Enab-PhpExtension to download it"
                 }
-                if ($foundExtensions.Count -ne 1) {
-                    throw "Multiple extensions match the name (or handle) `"$wantedExtension`""
-                }
-            }
-            $extensionToDisable = $foundExtensions[0]
-            if ($extensionToDisable.State -eq $Script:EXTENSIONSTATE_BUILTIN) {
-                throw ('The extension "' + $extensionToDisable.Name + '" is builtin: it can''t be disabled')
             }
-            if ($extensionToDisable.State -eq $Script:EXTENSIONSTATE_DISABLED) {
-                Write-Verbose ('The extension "' + $extensionToDisable.Name + '" is already disabled')
-            } elseif ($extensionToDisable.State -ne $Script:EXTENSIONSTATE_ENABLED) {
-                throw ('Unknown extension state: "' + $extensionToDisable.State + '"')
-            } else {
-                $extensionsToDisable += $extensionToDisable
+            foreach ($extensionToDisable in $foundExtensions) {
+                if ($extensionToDisable.State -eq $Script:EXTENSIONSTATE_BUILTIN) {
+                    throw ('The extension "' + $extensionToDisable.Name + '" is builtin: it can''t be disabled')
+                }
+                if ($extensionToDisable.State -eq $Script:EXTENSIONSTATE_DISABLED) {
+                    Write-Verbose ('The extension "' + $extensionToDisable.Name + '" is already disabled')
+                } elseif ($extensionToDisable.State -ne $Script:EXTENSIONSTATE_ENABLED) {
+                    throw ('Unknown extension state: "' + $extensionToDisable.State + '"')
+                } else {
+                    $extensionsToDisable += $extensionToDisable
+                }
             }
         }
         if ($extensionsToDisable) {
@@ -109,13 +107,12 @@ function Disable-PhpExtension() {
                         }
                     }
                 }
-                if (-Not($disabled)) {
-                    throw "The entry in the php.ini file has not been found (?)"
+                if ($disabled) {
+                    Set-PhpIniLine -Path $iniPath -Lines $newIniLines
+                    $extensionToDisable.State = $Script:EXTENSIONSTATE_ENABLED
+                    Write-Verbose ('The extension ' + $extensionToDisable.Name + ' v' + $extensionToDisable.Version + ' has been disabled')
+                    $iniLines = $newIniLines
                 }
-                Set-PhpIniLine -Path $iniPath -Lines $newIniLines
-                $extensionToDisable.State = $Script:EXTENSIONSTATE_ENABLED
-                Write-Verbose ('The extension ' + $extensionToDisable.Name + ' v' + $extensionToDisable.Version + ' has been disabled')
-                $iniLines = $newIniLines
             }
         }
     }

PhpManager/public/Enable-PhpExtension.ps1

@@ -45,14 +45,22 @@ function Enable-PhpExtension() {
         $extensionsToEnable = @()
         $allExtensions = Get-PhpExtension -Path $phpVersion.ExecutablePath
         foreach ($wantedExtension in $Extension) {
-            $foundExtensions = @($allExtensions | Where-Object { $_.Name -like $wantedExtension })
+            $match = $wantedExtension | Select-String -Pattern '^([^:]*)(?::(.*))?$'
+            $wantedExtensionName = $match.Matches.Groups[1].Value
+            $wantedExtensionVersion = $match.Matches.Groups[2].Value
+            $foundExtensions = @($allExtensions | Where-Object { $_.Name -like $wantedExtensionName -and $_.Version -like ($wantedExtensionVersion + '*') })
             if ($foundExtensions.Count -ne 1) {
-                $foundExtensions = @($allExtensions | Where-Object { $_.Handle -like $wantedExtension })
+                $foundExtensions = @($allExtensions | Where-Object { $_.Handle -like $wantedExtensionName -and $_.Version -like ($wantedExtensionVersion + '*') })
                 if ($foundExtensions.Count -eq 0) {
                     throw "Unable to find a locally available extension with name (or handle) `"$Extension`": use the Install-PhpExtension to download it"
                 }
                 if ($foundExtensions.Count -ne 1) {
-                    throw "Multiple extensions match the name (or handle) `"$Extension`""
+                    $msg = "Multiple extensions match the name (or handle) `"$Extension`":"
+                    foreach ($foundExtension in $foundExtensions) {
+                        $msg += "`n- handle: $($foundExtension.Handle) version $($foundExtension.Version)"
+                    }
+                    $msg += "`nYou can filter the extension to enable by adding :version to the -Extension parameter (example: `"-Extension '$($foundExtension.Handle):$($foundExtension.Version)'`")"
+                    throw $msg
                 }
             }
             $extensionsToEnable += $foundExtensions[0]

test/tests/Install-Enable-Extensions.Tests.ps1

@@ -58,6 +58,28 @@ Describe 'Install-Enable-Extensions' {
             $imagick.Type | Should -BeExactly 'Php'
             $imagick.State | Should -BeExactly 'Disabled'
         }
+        It -Name 'should handle multiple extension versions' {
+            $phpPath = Join-Path -Path $Global:PHPMANAGER_TESTPATH -ChildPath installs | Join-Path -ChildPath (New-Guid).Guid
+            Install-Php -Version 7.1 -Architecture x64 -ThreadSafe $true -Path $phpPath
+            $phpVersion = Get-Php -Path $phpPath
+            try {
+                Install-PhpExtension -Path $phpPath -Extension xdebug -Version 2.6 -DontEnable
+                Move-Item -LiteralPath (Join-Path -Path $phpVersion.ExtensionsPath -ChildPath 'php_xdebug.dll') -Destination (Join-Path -Path $phpVersion.ExtensionsPath -ChildPath 'php_xdebug-2.6')
+                Install-PhpExtension -Path $phpPath -Extension xdebug -Version 2.7 -MinimumStability alpha -DontEnable
+                Move-Item -LiteralPath (Join-Path -Path $phpVersion.ExtensionsPath -ChildPath 'php_xdebug.dll') -Destination (Join-Path -Path $phpVersion.ExtensionsPath -ChildPath 'php_xdebug-2.7')
+                Move-Item -LiteralPath (Join-Path -Path $phpVersion.ExtensionsPath -ChildPath 'php_xdebug-2.6') -Destination (Join-Path -Path $phpVersion.ExtensionsPath -ChildPath 'php_xdebug-2.6.dll')
+                Move-Item -LiteralPath (Join-Path -Path $phpVersion.ExtensionsPath -ChildPath 'php_xdebug-2.7') -Destination (Join-Path -Path $phpVersion.ExtensionsPath -ChildPath 'php_xdebug-2.7.dll')
+                { Enable-PhpExtension -Path $phpPath -Extension xdebug } | Should -Throw
+                { Enable-PhpExtension -Path $phpPath -Extension 'xdebug:2.6' } | Should -Not -Throw
+                Disable-PhpExtension -Path $phpPath -Extension xdebug
+                { Enable-PhpExtension -Path $phpPath -Extension 'xdebug:2.7' } | Should -Not -Throw
+            } finally {
+                try {
+                    Remove-Item -LiteralPath $phpPath -Recurse
+                } catch {
+                }
+            }
+        }
     } finally {
         foreach ($testCase in $testCases) {
             if (Test-Path -LiteralPath $testCase.path) {