validate sandbox names on sandbox create and restore (#3727)

Author: rolyatmax

modal/sandbox.py

@@ -29,7 +29,7 @@
 from ._utils.async_utils import TaskContext, synchronize_api
 from ._utils.deprecation import deprecation_warning
 from ._utils.mount_utils import validate_network_file_systems, validate_volumes
-from ._utils.name_utils import is_valid_object_name
+from ._utils.name_utils import check_object_name
 from ._utils.task_command_router_client import TaskCommandRouterClient
 from .client import _Client
 from .container_process import _ContainerProcess
@@ -79,16 +79,6 @@ def _validate_exec_args(args: Sequence[str]) -> None:
         )
 
 
-def _warn_if_invalid_name(name: str) -> None:
-    if not is_valid_object_name(name):
-        deprecation_warning(
-            (2025, 9, 3),
-            f"Sandbox name '{name}' will be considered invalid in a future release."
-            "\n\nNames may contain only alphanumeric characters, dashes, periods, and underscores,"
-            " must be shorter than 64 characters, and cannot conflict with App ID strings.",
-        )
-
-
 class DefaultSandboxNameOverride(str):
     """A singleton class that represents the default sandbox name override.
 
@@ -440,7 +430,7 @@ async def _create(
 
         _validate_exec_args(args)
         if name is not None:
-            _warn_if_invalid_name(name)
+            check_object_name(name, "Sandbox")
 
         if block_network and (encrypted_ports or h2_ports or unencrypted_ports):
             raise InvalidError("Cannot specify open ports when `block_network` is enabled")
@@ -1020,7 +1010,7 @@ async def _experimental_from_snapshot(
         client = client or await _Client.from_env()
 
         if name is not None and name != _DEFAULT_SANDBOX_NAME_OVERRIDE:
-            _warn_if_invalid_name(name)
+            check_object_name(name, "Sandbox")
 
         if name is _DEFAULT_SANDBOX_NAME_OVERRIDE:
             restore_req = api_pb2.SandboxRestoreRequest(