Skip to content

Commit 4748073

Browse files
authored
Fix wrong check of checkRequirement method
checkRequirement result contains a string or true. So the check will never have a false result and the error is not sent.
1 parent ab23a8e commit 4748073

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

core/src/Revolution/Rest/modRestController.php

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -668,8 +668,8 @@ public function post()
668668
$properties = $this->getProperties();
669669

670670
if (!empty($this->postRequiredFields)) {
671-
if (!$this->checkRequiredFields($this->postRequiredFields)) {
672-
return $this->failure($this->modx->lexicon('error'));
671+
if ($result = $this->checkRequiredFields($this->postRequiredFields) !== true) {
672+
return $this->failure($result);
673673
}
674674
}
675675

@@ -744,8 +744,8 @@ public function put()
744744
}
745745

746746
if (!empty($this->putRequiredFields)) {
747-
if (!$this->checkRequiredFields($this->putRequiredFields)) {
748-
return $this->failure();
747+
if ($result = $this->checkRequiredFields($this->putRequiredFields) !== true) {
748+
return $this->failure($result);
749749
}
750750
}
751751

@@ -819,8 +819,8 @@ public function delete()
819819
}
820820

821821
if (!empty($this->deleteRequiredFields)) {
822-
if (!$this->checkRequiredFields($this->deleteRequiredFields)) {
823-
return $this->failure();
822+
if ($result = $this->checkRequiredFields($this->deleteRequiredFields) !== true) {
823+
return $this->failure($result);
824824
}
825825
}
826826

0 commit comments

Comments
 (0)