Update modX.php

smg6511 · smg6511 · commit ac8a2868a451 · 2025-05-22T00:12:42.000-04:00
Make array checking strict
diff --git a/core/src/Revolution/modX.php b/core/src/Revolution/modX.php
@@ -409,7 +409,7 @@ public static function toQueryString(array $parameters = [], $numPrefix = '', $a
      */
     public function paramValueIsTrue(array $params, $key, bool $returnBoolAsString = false)
     {
-        if (isset($params[$key]) && in_array($params[$key], ['true', true, '1', 1])) {
+        if (isset($params[$key]) && in_array($params[$key], ['true', true, '1', 1], true)) {
             return $returnBoolAsString ? 'true' : true ;
         }
         return $returnBoolAsString ? 'false' : false ;

Original file line number	Diff line number	Diff line change
`@@ -409,7 +409,7 @@ public static function toQueryString(array $parameters = [], $numPrefix = '', $a`
`409`	`409`	`*/`
`410`	`410`	`public function paramValueIsTrue(array $params, $key, bool $returnBoolAsString = false)`
`411`	`411`	`{`
`412`		`- if (isset($params[$key]) && in_array($params[$key], ['true', true, '1', 1])) {`
	`412`	`+ if (isset($params[$key]) && in_array($params[$key], ['true', true, '1', 1], true)) {`
`413`	`413`	`return $returnBoolAsString ? 'true' : true ;`
`414`	`414`	`}`
`415`	`415`	`return $returnBoolAsString ? 'false' : false ;`