Skip to content

Commit 1230598

Browse files
Fix code review remarks
1 parent eae217c commit 1230598

File tree

3 files changed

+8
-4
lines changed

3 files changed

+8
-4
lines changed

lib/mongo/operation/shared/executable.rb

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,11 @@ def get_result(connection, context, options = {})
107107
message = build_message(connection, context)
108108
connection.tracer.trace_command(message, context, connection) do
109109
result = result_class.new(*dispatch_message(message, connection, context, options), context: context, connection: connection)
110-
yield result
110+
if block_given?
111+
yield result
112+
else
113+
result
114+
end
111115
end
112116
end
113117

lib/mongo/tracing.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,10 +19,10 @@ module Mongo
1919
module Tracing
2020
# Creates a new OpenTelemetry tracer for instrumenting MongoDB operations.
2121
#
22-
# @param enabled [Boolean, nil] Whether tracing is enabled. Defautl to nil, which
22+
# @param enabled [Boolean, nil] Whether tracing is enabled. Default to nil, which
2323
# means it will check the environment variable OTEL_RUBY_INSTRUMENTATION_MONGODB_ENABLED.
2424
# See +Mongo::Tracing::OpenTelemetry::Tracer+ for details.
25-
# @param query_text_max_length [Integer, nil] Maximum length for captured query text. Defaults to nil,
25+
# @param query_text_max_length [Integer, nil] Maximum length for captured query text. Default to nil,
2626
# which means it will check the environment variable OTEL_RUBY_INSTRUMENTATION_MONGODB_QUERY_TEXT_MAX_LENGTH.
2727
# See +Mongo::Tracing::OpenTelemetry::Tracer+ for details.
2828
# @param otel_tracer [OpenTelemetry::Trace::Tracer, nil] Custom OpenTelemetry tracer instance.

lib/mongo/tracing/open_telemetry/tracer.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ def initialize(enabled: nil, query_text_max_length: nil, otel_tracer: nil)
5858

5959
# Whether OpenTelemetry is enabled or not.
6060
#
61-
# # @return [Boolean] true if OpenTelemetry is enabled, false otherwise.
61+
# @return [Boolean] true if OpenTelemetry is enabled, false otherwise.
6262
def enabled?
6363
@enabled
6464
end

0 commit comments

Comments
 (0)