[GTK] Make WebExtensions compile on Linux

https://webkit.org/b/284215

Reviewed by Timothy Hatcher.

Create a CMake option to enable WK_WEB_EXTENSIONS on Linux, and fixes issues regarding compile WebKitGtk with WK_WEB_EXTENSIONS enabled.

* Source/WTF/wtf/PlatformEnableGlib.h:
* Source/WebCore/platform/text/LocaleICU.cpp:
(WebCore::LocaleICU::defaultWritingDirection const):
* Source/WebCore/platform/text/LocaleICU.h:
* Source/WebCore/platform/text/PlatformLocale.h:
* Source/WebKit/CMakeLists.txt:
* Source/WebKit/Shared/Extensions/WebExtensionControllerParameters.h:
* Source/WebKit/Shared/Extensions/WebExtensionControllerParameters.serialization.in:
* Source/WebKit/Shared/Extensions/WebExtensionTab.serialization.in:
* Source/WebKit/Shared/Extensions/WebExtensionTabParameters.h:
* Source/WebKit/Shared/Extensions/WebExtensionWindow.serialization.in:
* Source/WebKit/Shared/Extensions/WebExtensionWindowParameters.h:
* Source/WebKit/UIProcess/API/APIPageConfiguration.cpp:
(API::PageConfiguration::maskedURLSchemes const):
* Source/WebKit/UIProcess/Extensions/WebExtensionAction.h:
* Source/WebKit/UIProcess/Extensions/WebExtensionContext.h:
* Source/WebKit/UIProcess/Extensions/WebExtensionController.cpp:
(WebKit::WebExtensionController::WebExtensionController):
* Source/WebKit/UIProcess/Extensions/WebExtensionController.h:
* Source/WebKit/UIProcess/Extensions/WebExtensionControllerConfiguration.cpp:
* Source/WebKit/UIProcess/Extensions/WebExtensionControllerConfiguration.h:
* Source/WebKit/UIProcess/Extensions/WebExtensionDataRecord.h:
* Source/WebKit/UIProcess/Extensions/WebExtensionDynamicScripts.h:
* Source/WebKit/UIProcess/Extensions/WebExtensionMatchPattern.cpp:
* Source/WebKit/UIProcess/Extensions/WebExtensionMessagePort.h:
* Source/WebKit/UIProcess/Extensions/WebExtensionTab.h:
* Source/WebKit/UIProcess/Extensions/WebExtensionWindow.h:
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::m_pageForTesting):
(WebKit::WebPageProxy::close):
(WebKit::WebPageProxy::resourceLoadDidSendRequest):
(WebKit::WebPageProxy::resourceLoadDidPerformHTTPRedirection):
(WebKit::WebPageProxy::resourceLoadDidReceiveChallenge):
(WebKit::WebPageProxy::resourceLoadDidReceiveResponse):
(WebKit::WebPageProxy::resourceLoadDidCompleteWithError):
(WebKit::WebPageProxy::creationParameters):
* Source/WebKit/WebProcess/Extensions/API/WebExtensionAPIEvent.h:
* Source/WebKit/WebProcess/Extensions/API/WebExtensionAPILocalization.h:
* Source/WebKit/WebProcess/Extensions/API/WebExtensionAPIWebNavigationEvent.h:
* Source/WebKit/WebProcess/Extensions/API/WebExtensionAPIWebRequestEvent.h:
* Source/WebKit/WebProcess/Extensions/API/WebExtensionAPIWindowsEvent.h:
* Source/WebKit/WebProcess/Extensions/Bindings/JSWebExtensionWrapper.h:
* Source/WebKit/WebProcess/Extensions/WebExtensionContextProxy.h:
* Source/WebKit/WebProcess/Extensions/WebExtensionControllerProxy.h:
* Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp:
(WebKit::addParametersShared):
* Source/WebKit/WebProcess/WebCoreSupport/WebLocalFrameLoaderClient.cpp:
(WebKit::WebLocalFrameLoaderClient::dispatchDidStartProvisionalLoad):
(WebKit::WebLocalFrameLoaderClient::dispatchDidCommitLoad):
(WebKit::WebLocalFrameLoaderClient::dispatchDidFailProvisionalLoad):
(WebKit::WebLocalFrameLoaderClient::dispatchDidFailLoad):
(WebKit::WebLocalFrameLoaderClient::dispatchDidFinishLoad):
(WebKit::WebLocalFrameLoaderClient::dispatchGlobalObjectAvailable):
(WebKit::WebLocalFrameLoaderClient::dispatchServiceWorkerGlobalObjectAvailable):
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::m_textAnimationController):
* Source/WebKit/WebProcess/WebPage/WebPage.h:

Canonical link: https://commits.webkit.org/287517@main

Author: ItsJamie9494

Source/WebCore/platform/text/LocaleICU.cpp

@@ -31,10 +31,14 @@
 #include "config.h"
 #include "LocaleICU.h"
 
+#include "LocaleToScriptMapping.h"
 #include "LocalizedStrings.h"
+#include <hb-icu.h>
+#include <hb.h>
 #include <limits>
 #include <unicode/udatpg.h>
 #include <unicode/uloc.h>
+#include <unicode/uscript.h>
 #include <wtf/DateMath.h>
 #include <wtf/text/StringBuffer.h>
 #include <wtf/text/StringBuilder.h>
@@ -66,6 +70,21 @@ LocaleICU::~LocaleICU()
 #endif
 }
 
+Locale::WritingDirection LocaleICU::defaultWritingDirection() const
+{
+    UScriptCode icuScript = localeToScriptCodeForFontSelection(m_locale.span());
+    hb_script_t script = hb_icu_script_to_script(icuScript);
+
+    switch (hb_script_get_horizontal_direction(script)) {
+    case HB_DIRECTION_LTR:
+        return WritingDirection::LeftToRight;
+    case HB_DIRECTION_RTL:
+        return WritingDirection::RightToLeft;
+    default:
+        return WritingDirection::Default;
+    }
+}
+
 #if !UCONFIG_NO_FORMATTING
 String LocaleICU::decimalSymbol(UNumberFormatSymbol symbol)
 {

Source/WebCore/platform/text/LocaleICU.h

@@ -47,6 +47,8 @@ class LocaleICU : public Locale {
     explicit LocaleICU(const char*);
     virtual ~LocaleICU();
 
+    Locale::WritingDirection defaultWritingDirection() const override;
+
 #if ENABLE(DATE_AND_TIME_INPUT_TYPES)
     String dateFormat() override;
     String monthFormat() override;

Source/WebCore/platform/text/PlatformLocale.h

@@ -65,7 +65,7 @@ class Locale {
         RightToLeft
     };
 
-#if PLATFORM(COCOA)
+#if PLATFORM(GTK) || PLATFORM(WPE) || PLATFORM(COCOA)
     // Returns the default writing direction for the specified locale.
     virtual WritingDirection defaultWritingDirection() const = 0;
 #endif

Source/WebKit/CMakeLists.txt

@@ -60,6 +60,7 @@ set(WebKit_PRIVATE_INCLUDE_DIRECTORIES
     "${WEBKIT_DIR}/UIProcess/Automation"
     "${WEBKIT_DIR}/UIProcess/DigitalCredentials"
     "${WEBKIT_DIR}/UIProcess/Downloads"
+    "${WEBKIT_DIR}/UIProcess/Extensions"
     "${WEBKIT_DIR}/UIProcess/Gamepad"
     "${WEBKIT_DIR}/UIProcess/GPU"
     "${WEBKIT_DIR}/UIProcess/Inspector"
@@ -85,6 +86,9 @@ set(WebKit_PRIVATE_INCLUDE_DIRECTORIES
     "${WEBKIT_DIR}/WebProcess/Databases"
     "${WEBKIT_DIR}/WebProcess/Databases/IndexedDB"
     "${WEBKIT_DIR}/WebProcess/EncryptedMedia"
+    "${WEBKIT_DIR}/WebProcess/Extensions"
+    "${WEBKIT_DIR}/WebProcess/Extensions/API"
+    "${WEBKIT_DIR}/WebProcess/Extensions/Bindings"
     "${WEBKIT_DIR}/WebProcess/FileAPI"
     "${WEBKIT_DIR}/WebProcess/FullScreen"
     "${WEBKIT_DIR}/WebProcess/Gamepad"
@@ -132,6 +136,43 @@ list(APPEND WebKit_UNIFIED_SOURCE_LIST_FILES
     "Platform/Sources.txt"
 )
 
+set(WebKit_BINDINGS_IN_FILES
+    WebProcess/Extensions/Interfaces/WebExtensionAPIAction
+    WebProcess/Extensions/Interfaces/WebExtensionAPIAlarms
+    WebProcess/Extensions/Interfaces/WebExtensionAPICommands
+    WebProcess/Extensions/Interfaces/WebExtensionAPICookies
+    WebProcess/Extensions/Interfaces/WebExtensionAPIDeclarativeNetRequest
+    WebProcess/Extensions/Interfaces/WebExtensionAPIDevTools
+    WebProcess/Extensions/Interfaces/WebExtensionAPIDevToolsExtensionPanel
+    WebProcess/Extensions/Interfaces/WebExtensionAPIDevToolsInspectedWindow
+    WebProcess/Extensions/Interfaces/WebExtensionAPIDevToolsNetwork
+    WebProcess/Extensions/Interfaces/WebExtensionAPIDevToolsPanels
+    WebProcess/Extensions/Interfaces/WebExtensionAPIEvent
+    WebProcess/Extensions/Interfaces/WebExtensionAPIExtension
+    WebProcess/Extensions/Interfaces/WebExtensionAPILocalization
+    WebProcess/Extensions/Interfaces/WebExtensionAPIMenus
+    WebProcess/Extensions/Interfaces/WebExtensionAPINamespace
+    WebProcess/Extensions/Interfaces/WebExtensionAPINotifications
+    WebProcess/Extensions/Interfaces/WebExtensionAPIPermissions
+    WebProcess/Extensions/Interfaces/WebExtensionAPIPort
+    WebProcess/Extensions/Interfaces/WebExtensionAPIRuntime
+    WebProcess/Extensions/Interfaces/WebExtensionAPIScripting
+    WebProcess/Extensions/Interfaces/WebExtensionAPISidePanel
+    WebProcess/Extensions/Interfaces/WebExtensionAPISidebarAction
+    WebProcess/Extensions/Interfaces/WebExtensionAPIStorage
+    WebProcess/Extensions/Interfaces/WebExtensionAPIStorageArea
+    WebProcess/Extensions/Interfaces/WebExtensionAPITabs
+    WebProcess/Extensions/Interfaces/WebExtensionAPITest
+    WebProcess/Extensions/Interfaces/WebExtensionAPIWebNavigation
+    WebProcess/Extensions/Interfaces/WebExtensionAPIWebNavigationEvent
+    WebProcess/Extensions/Interfaces/WebExtensionAPIWebPageNamespace
+    WebProcess/Extensions/Interfaces/WebExtensionAPIWebPageRuntime
+    WebProcess/Extensions/Interfaces/WebExtensionAPIWebRequest
+    WebProcess/Extensions/Interfaces/WebExtensionAPIWebRequestEvent
+    WebProcess/Extensions/Interfaces/WebExtensionAPIWindows
+    WebProcess/Extensions/Interfaces/WebExtensionAPIWindowsEvent
+)
+
 set(WebKit_MESSAGES_IN_FILES
     GPUProcess/GPUConnectionToWebProcess
     GPUProcess/GPUProcess
@@ -243,6 +284,9 @@ set(WebKit_MESSAGES_IN_FILES
     UIProcess/DigitalCredentials/DigitalCredentialsCoordinatorProxy
     UIProcess/DrawingAreaProxy
 
+    UIProcess/Extensions/WebExtensionContext
+    UIProcess/Extensions/WebExtensionController
+
     UIProcess/Media/RemoteMediaSessionCoordinatorProxy
 
     UIProcess/SpeechRecognitionRemoteRealtimeMediaSourceManager
@@ -279,6 +323,9 @@ set(WebKit_MESSAGES_IN_FILES
 
     WebProcess/Databases/IndexedDB/WebIDBConnectionToServer
 
+    WebProcess/Extensions/WebExtensionContextProxy
+    WebProcess/Extensions/WebExtensionControllerProxy
+
     WebProcess/FullScreen/WebFullScreenManager
 
     WebProcess/GPU/GPUProcessConnection
@@ -513,7 +560,25 @@ set(WebKit_SERIALIZATION_IN_FILES
 
     Shared/Databases/IndexedDB/WebIDBResult.serialization.in
 
+    Shared/Extensions/WebExtensionActionClickBehavior.serialization.in
+    Shared/Extensions/WebExtensionAlarmParameters.serialization.in
+    Shared/Extensions/WebExtensionCommandParameters.serialization.in
+    Shared/Extensions/WebExtensionContentWorldType.serialization.in
+    Shared/Extensions/WebExtensionContext.serialization.in
+    Shared/Extensions/WebExtensionContextParameters.serialization.in
+    Shared/Extensions/WebExtensionControllerParameters.serialization.in
+    Shared/Extensions/WebExtensionCookieParameters.serialization.in
+    Shared/Extensions/WebExtensionDynamicScripts.serialization.in
     Shared/Extensions/WebExtensionEventListenerType.serialization.in
+    Shared/Extensions/WebExtensionFrameParameters.serialization.in
+    Shared/Extensions/WebExtensionMatchedRuleParameters.serialization.in
+    Shared/Extensions/WebExtensionMenuItem.serialization.in
+    Shared/Extensions/WebExtensionMessageSenderParameters.serialization.in
+    Shared/Extensions/WebExtensionMessageTargetParameters.serialization.in
+    Shared/Extensions/WebExtensionSidebarParameters.serialization.in
+    Shared/Extensions/WebExtensionStorage.serialization.in
+    Shared/Extensions/WebExtensionTab.serialization.in
+    Shared/Extensions/WebExtensionWindow.serialization.in
 
     Shared/Gamepad/GamepadData.serialization.in
 
@@ -798,6 +863,36 @@ macro(GENERATE_MESSAGE_SOURCES _output_source _inputs)
 endmacro()
 GENERATE_MESSAGE_SOURCES(WebKit_DERIVED_SOURCES "${WebKit_MESSAGES_IN_FILES}")
 
+# Helper macro which wraps the bindings script
+#   _output_source is a list name which will contain generated sources.(eg. WebKit_SOURCES)
+#   _inputs are .idl files to generate.
+macro(GENERATE_IDL_BINDINGS _output_source _inputs)
+    unset(_input_files)
+    unset(_outputs)
+    foreach (_file IN ITEMS ${_inputs})
+        get_filename_component(_name ${_file} NAME_WE)
+        list(APPEND _input_files ${WEBKIT_DIR}/${_file}.idl)
+        list(APPEND _outputs
+            ${WebKit_DERIVED_SOURCES_DIR}/JS${_name}.mm
+
+            ${WebKit_DERIVED_SOURCES_DIR}/JS${_name}.h
+        )
+        list(APPEND ${_output_source} ${WebKit_DERIVED_SOURCES_DIR}/JS${_name}.h)
+    endforeach ()
+
+    add_custom_command(
+        OUTPUT
+            ${_outputs}
+        MAIN_DEPENDENCY ${WEBCORE_DIR}/bindings/scripts/generate-bindings-all.pl
+        DEPENDS
+            ${_input_files}
+        COMMAND ${PERL_EXECUTABLE} -I "${WEBKIT_DIR}/WebProcess/Extensions/Bindings/Scripts" ${WEBCORE_DIR}/bindings/scripts/generate-bindings.pl --outputDir . --generator Extensions --idlAttributesFile "${WEBKIT_DIR}/WebProcess/Extensions/Bindings/Scripts/IDLAttributes.json" --idlFileNamesList WebExtensionIDLFileNamesList.txt ${_input_files}
+        WORKING_DIRECTORY ${WebKit_DERIVED_SOURCES_DIR}
+        VERBATIM
+    )
+endmacro()
+GENERATE_IDL_BINDINGS(WebKit_DERIVED_SOURCES "${WebKit_BINDINGS_IN_FILES}")
+
 foreach (in_file ${WebKit_SERIALIZATION_IN_FILES})
     list(APPEND WebKit_SERIALIZATION_DEPENDENCIES "${WEBKIT_DIR}/${in_file}")
 endforeach ()

Source/WebKit/Shared/Extensions/WebExtensionControllerParameters.h

@@ -37,9 +37,7 @@ struct WebExtensionControllerParameters {
 
     bool testingMode { false };
 
-#if PLATFORM(COCOA)
     Vector<WebExtensionContextParameters> contextParameters;
-#endif
 };
 
 } // namespace WebKit

Source/WebKit/Shared/Extensions/WebExtensionControllerParameters.serialization.in

@@ -27,9 +27,7 @@ struct WebKit::WebExtensionControllerParameters {
 
     bool testingMode;
 
-#if PLATFORM(COCOA)
     Vector<WebKit::WebExtensionContextParameters> contextParameters;
-#endif
 }
 
 #endif

Source/WebKit/Shared/Extensions/WebExtensionTab.serialization.in

@@ -32,7 +32,9 @@ struct WebKit::WebExtensionTabParameters {
 
     std::optional<WebKit::WebExtensionWindowIdentifier> windowIdentifier;
     std::optional<size_t> index;
+#if PLATFORM(COCOA)
     std::optional<CGSize> size;
+#endif
 
     std::optional<WebKit::WebExtensionTabIdentifier> parentTabIdentifier;
 

Source/WebKit/Shared/Extensions/WebExtensionTabParameters.h

@@ -41,7 +41,9 @@ struct WebExtensionTabParameters {
 
     std::optional<WebExtensionWindowIdentifier> windowIdentifier;
     std::optional<size_t> index;
+#if PLATFORM(COCOA)
     std::optional<CGSize> size;
+#endif
 
     std::optional<WebExtensionTabIdentifier> parentTabIdentifier;
 

Source/WebKit/Shared/Extensions/WebExtensionWindow.serialization.in

@@ -32,7 +32,9 @@ struct WebKit::WebExtensionWindowParameters {
 
     std::optional<Vector<WebKit::WebExtensionTabParameters>> tabs;
 
+#if PLATFORM(COCOA)
     std::optional<CGRect> frame;
+#endif
 
     std::optional<bool> focused;
     std::optional<bool> privateBrowsing;

Source/WebKit/Shared/Extensions/WebExtensionWindowParameters.h

@@ -42,7 +42,9 @@ struct WebExtensionWindowParameters {
 
     std::optional<Vector<WebExtensionTabParameters>> tabs;
 
+#if PLATFORM(COCOA)
     std::optional<CGRect> frame;
+#endif
 
     std::optional<bool> focused;
     std::optional<bool> privateBrowsing;