Make funcs in tests 'helpers' (#135)

Author: peteski22

cmd/add_test.go

@@ -72,6 +72,12 @@ func (f *fakeBuilder) Build() (registry.PackageProvider, error) {
 	return f.reg, f.err
 }
 
+// testIntPtr returns a pointer to an int
+func testIntPtr(t *testing.T, i int) *int {
+	t.Helper()
+	return &i
+}
+
 func TestAddCmd_Success(t *testing.T) {
 	cfg := &fakeConfig{}
 	pkg := packages.Server{
@@ -411,10 +417,6 @@ func TestSelectRuntime(t *testing.T) {
 	}
 }
 
-func intPtr(i int) *int {
-	return &i
-}
-
 func TestParseServerEntry(t *testing.T) {
 	t.Parallel()
 
@@ -533,8 +535,16 @@ func TestParseServerEntry(t *testing.T) {
 			availableTools:    []string{"read", "write"},
 			requestedTools:    []string{"read"},
 			arguments: packages.Arguments{
-				"path":       {VariableType: packages.VariableTypeArgPositional, Position: intPtr(1), Required: true},
-				"mode":       {VariableType: packages.VariableTypeArgPositional, Position: intPtr(2), Required: true},
+				"path": {
+					VariableType: packages.VariableTypeArgPositional,
+					Position:     testIntPtr(t, 1),
+					Required:     true,
+				},
+				"mode": {
+					VariableType: packages.VariableTypeArgPositional,
+					Position:     testIntPtr(t, 2),
+					Required:     true,
+				},
 				"--format":   {VariableType: packages.VariableTypeArg, Required: true},
 				"--encoding": {VariableType: packages.VariableTypeArg, Required: false},
 			},

internal/provider/mcpm/registry_test.go

@@ -17,8 +17,9 @@ import (
 	"github.com/mozilla-ai/mcpd/v2/internal/runtime"
 )
 
-// intPtr returns a pointer to an int
-func intPtr(i int) *int {
+// testIntPtr returns a pointer to an int
+func testIntPtr(t *testing.T, i int) *int {
+	t.Helper()
 	return &i
 }
 
@@ -447,7 +448,7 @@ func TestRegistry_ExtractArgumentMetadata_EdgeCases(t *testing.T) {
 					Required:     true,
 					Description:  "API key",
 					Example:      "key123",
-					Position:     intPtr(1),
+					Position:     testIntPtr(t, 1),
 				},
 			},
 		},
@@ -577,15 +578,15 @@ func TestRegistry_ExtractArgumentMetadata_WithTestdata(t *testing.T) {
 					Required:     true,
 					Description:  "The base directory that the server will have access to",
 					Example:      "/Users/username/Documents",
-					Position:     intPtr(1),
+					Position:     testIntPtr(t, 1),
 				},
 				"USER_FILESYSTEM_ALLOWED_DIR": {
 					Name:         "USER_FILESYSTEM_ALLOWED_DIR",
 					VariableType: packages.VariableTypeArgPositional,
 					Required:     false,
 					Description:  "Additional allowed directory for file access",
 					Example:      "/Users/username/Projects",
-					Position:     intPtr(2),
+					Position:     testIntPtr(t, 2),
 				},
 			},
 		},
@@ -631,7 +632,7 @@ func TestRegistry_ExtractArgumentMetadata_WithTestdata(t *testing.T) {
 					Required:     true,
 					Description:  "Directory for data storage",
 					Example:      "/path/to/data",
-					Position:     intPtr(1),
+					Position:     testIntPtr(t, 1),
 				},
 			},
 		},
@@ -752,7 +753,7 @@ func TestRegistry_ExtractArgumentMetadata_SyntheticCases(t *testing.T) {
 					Required:     true,
 					Description:  "Base directory",
 					Example:      "/path/to/files",
-					Position:     intPtr(1),
+					Position:     testIntPtr(t, 1),
 				},
 			},
 		},
@@ -1080,15 +1081,15 @@ func TestRegistry_ExtractArgumentMetadata_ComprehensiveScenarios(t *testing.T) {
 			Required:     true,
 			Description:  "Base directory for files",
 			Example:      "/path/to/files",
-			Position:     intPtr(1),
+			Position:     testIntPtr(t, 1),
 		},
 		"OPTIONAL_DIR": {
 			Name:         "OPTIONAL_DIR",
 			VariableType: packages.VariableTypeArgPositional,
 			Required:     false,
 			Description:  "Optional directory",
 			Example:      "/path/to/optional",
-			Position:     intPtr(2),
+			Position:     testIntPtr(t, 2),
 		},
 	}