Bugfix #31040 ⁃ Fix testOnboardingCard_viewDidAppear_viewSendsCardView failing test on iOS 17.5 (#31047)

yoanarios · web-flow · commit 4425a47a4e80 · 2025-12-03T12:52:40.000-05:00
Call manually to viewDidAppear on iOS 18 and above
diff --git a/firefox-ios/firefox-ios-tests/Tests/ClientTests/OnboardingTests/OnboardingTelemetryDelegationTests.swift b/firefox-ios/firefox-ios-tests/Tests/ClientTests/OnboardingTests/OnboardingTelemetryDelegationTests.swift
@@ -31,7 +31,13 @@ class OnboardingTelemetryDelegationTests: XCTestCase {
             XCTFail("expected a view controller, but got nothing")
             return
         }
-        firstVC.viewDidAppear(true)
+
+        // On iOS 17 and earlier, the system already triggers a viewDidAppear call,
+        // so calling it manually would cause the expected count to fail.
+        // In iOS 18 and later, this behavior changed and we must call viewDidAppear manually.
+        if #available(iOS 18, *) {
+            firstVC.viewDidAppear(true)
+        }
 
         try testEventMetricRecordingSuccess(metric: GleanMetrics.Onboarding.cardView)
     }

Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,13 @@ class OnboardingTelemetryDelegationTests: XCTestCase {`
`31`	`31`	`XCTFail("expected a view controller, but got nothing")`
`32`	`32`	`return`
`33`	`33`	`}`
`34`		`- firstVC.viewDidAppear(true)`
	`34`	`+`
	`35`	`+ // On iOS 17 and earlier, the system already triggers a viewDidAppear call,`
	`36`	`+ // so calling it manually would cause the expected count to fail.`
	`37`	`+ // In iOS 18 and later, this behavior changed and we must call viewDidAppear manually.`
	`38`	`+ if #available(iOS 18, *) {`
	`39`	`+ firstVC.viewDidAppear(true)`
	`40`	`+ }`
`35`	`41`
`36`	`42`	`try testEventMetricRecordingSuccess(metric: GleanMetrics.Onboarding.cardView)`
`37`	`43`	`}`