Bugfix FXIOS-29410 [Menu] Fix overlap of “Protections are ON” label with domain name at large text sizes (#29429)

* Update site protections header layout constraints

Refactored MenuSiteProtectionsHeader to use prioritized top constraints for siteProtectionsContent, improving alignment and flexibility. Adjusted leading anchor to align with contentLabels and applied horizontal padding offset.

* Update MenuSiteProtectionsHeader.swift

Co-authored-by: Isabella <[email protected]>

---------

Co-authored-by: Isabella <[email protected]>

Author: Aniket-pd

BrowserKit/Sources/MenuKit/MenuSiteProtectionsHeader.swift

@@ -122,6 +122,17 @@ public final class MenuSiteProtectionsHeader: UIView, ThemeApplicable {
         siteProtectionsContent.addArrangedSubview(siteProtectionsLabel)
         siteProtectionsContent.addArrangedSubview(siteProtectionsMoreSettingsIcon)
 
+        let siteProtectionsTopFromFavicon = siteProtectionsContent.topAnchor.constraint(
+            greaterThanOrEqualTo: favicon.bottomAnchor,
+            constant: UX.siteProtectionsContentTopMargin
+        )
+
+        let siteProtectionsTopFromLabels = siteProtectionsContent.topAnchor.constraint(
+            equalTo: contentLabels.bottomAnchor,
+            constant: UX.siteProtectionsContentTopMargin
+        )
+        siteProtectionsTopFromLabels.priority = .defaultHigh
+        let iconAlignmentOffset = -UX.siteProtectionsContentHorizontalPadding
         NSLayoutConstraint.activate([
             contentLabels.topAnchor.constraint(equalTo: self.topAnchor),
             contentLabels.trailingAnchor.constraint(equalTo: closeButton.leadingAnchor,
@@ -139,14 +150,17 @@ public final class MenuSiteProtectionsHeader: UIView, ThemeApplicable {
             siteProtectionsIcon.widthAnchor.constraint(equalToConstant: UX.siteProtectionsIcon),
             siteProtectionsMoreSettingsIcon.widthAnchor.constraint(equalToConstant: UX.siteProtectionsMoreSettingsIcon),
 
-            siteProtectionsContent.topAnchor.constraint(equalTo: favicon.bottomAnchor,
-                                                        constant: UX.siteProtectionsContentTopMargin),
+            siteProtectionsTopFromLabels,
+            siteProtectionsTopFromFavicon,
             siteProtectionsContent.trailingAnchor.constraint(lessThanOrEqualTo: closeButton.leadingAnchor),
             siteProtectionsContent.bottomAnchor.constraint(equalTo: self.bottomAnchor),
 
             closeButton.widthAnchor.constraint(equalToConstant: UX.closeButtonSize),
             closeButton.heightAnchor.constraint(equalToConstant: UX.closeButtonSize),
-            siteProtectionsContent.leadingAnchor.constraint(equalTo: favicon.leadingAnchor)
+            siteProtectionsContent.leadingAnchor.constraint(
+                equalTo: contentLabels.leadingAnchor,
+                constant: iconAlignmentOffset
+            )
         ])
 
         closeButton.layer.cornerRadius = 0.5 * UX.closeButtonSize