Skip to content

Commit 929dc30

Browse files
Bugfix FXIOS-00000 Fix crash in FxAWebViewModelTests (#31032)
Fix crash in unit tests
1 parent b9945b3 commit 929dc30

File tree

2 files changed

+8
-3
lines changed

2 files changed

+8
-3
lines changed

firefox-ios/RustFxA/FxAWebViewModel.swift

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ class FxAWebViewModel: FeatureFlaggable {
4040
fileprivate let profile: Profile
4141
fileprivate var deepLinkParams: FxALaunchParams
4242
fileprivate(set) var baseURL: URL?
43-
let fxAWebViewTelemetry = FxAWebViewTelemetry()
43+
let fxAWebViewTelemetry: FxAWebViewTelemetry
4444
private let shouldAskForNotificationPermission: Bool
4545
private let logger: Logger
4646
// This is not shown full-screen, use mobile UA
@@ -98,12 +98,14 @@ class FxAWebViewModel: FeatureFlaggable {
9898
profile: Profile,
9999
deepLinkParams: FxALaunchParams,
100100
shouldAskForNotificationPermission: Bool = true,
101-
logger: Logger = DefaultLogger.shared) {
101+
logger: Logger = DefaultLogger.shared,
102+
telemetry: FxAWebViewTelemetry = FxAWebViewTelemetry()) {
102103
self.pageType = pageType
103104
self.profile = profile
104105
self.deepLinkParams = deepLinkParams
105106
self.shouldAskForNotificationPermission = shouldAskForNotificationPermission
106107
self.logger = logger
108+
self.fxAWebViewTelemetry = telemetry
107109
}
108110

109111
var onDismissController: (() -> Void)?

firefox-ios/firefox-ios-tests/Tests/ClientTests/FxAWebViewModelTests.swift

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,10 @@ class FxAWebViewModelTests: XCTestCase {
1414
override func setUp() {
1515
super.setUp()
1616
deeplinkParams = FxALaunchParams(entrypoint: .browserMenu, query: ["test_key": "test_value"])
17-
viewModel = FxAWebViewModel(pageType: .settingsPage, profile: MockProfile(), deepLinkParams: deeplinkParams)
17+
viewModel = FxAWebViewModel(pageType: .settingsPage,
18+
profile: MockProfile(),
19+
deepLinkParams: deeplinkParams,
20+
telemetry: FxAWebViewTelemetry(telemetryWrapper: MockTelemetryWrapper()))
1821
}
1922

2023
override func tearDown() {

0 commit comments

Comments
 (0)