Add FXIOS-14379 [Performance] Add back equatable for BVC state (#31217)

* Add back equatable for BVC state

* add ticket number

* fix tests

Author: Cramsden

firefox-ios/Client/Frontend/Browser/BrowserViewController/State/BrowserNavigationType.swift

@@ -7,7 +7,7 @@ import enum MozillaAppServices.VisitType
 import SummarizeKit
 
 /// View types that the browser coordinator can navigate to
-enum BrowserNavigationDestination {
+enum BrowserNavigationDestination: Equatable {
     // Native views
     case contextMenu
     case settings(Route.SettingsSection)
@@ -29,7 +29,7 @@ enum BrowserNavigationDestination {
     case shareSheet(ShareSheetConfiguration)
 }
 
-struct ShareSheetConfiguration {
+struct ShareSheetConfiguration: Equatable {
     let shareType: ShareType
     let shareMessage: ShareMessage?
     let sourceView: UIView
@@ -39,7 +39,7 @@ struct ShareSheetConfiguration {
 }
 
 /// This type exists as a field on the BrowserViewControllerState
-struct NavigationDestination {
+struct NavigationDestination: Equatable {
     let destination: BrowserNavigationDestination
     let url: URL?
     let isPrivate: Bool?

firefox-ios/Client/Frontend/Browser/BrowserViewController/State/BrowserViewControllerState.swift

@@ -10,7 +10,7 @@ import WebKit
 import SummarizeKit
 
 struct BrowserViewControllerState: ScreenState {
-    enum NavigationType {
+    enum NavigationType: Equatable {
         case home
         case back
         case forward

firefox-ios/Client/Frontend/Browser/BrowserViewController/State/BrowserViewType.swift

@@ -4,7 +4,7 @@
 
 import Foundation
 
-enum BrowserViewType {
+enum BrowserViewType: Equatable {
     case normalHomepage
     case privateHomepage
     case webview

firefox-ios/Client/Frontend/Share/ShareTab.swift

@@ -5,6 +5,8 @@
 import Foundation
 
 protocol ShareTab: Sendable {
+    nonisolated var tabUUID: TabUUID { get }
+
     @MainActor
     var displayTitle: String { get }
     @MainActor

firefox-ios/Client/Frontend/Share/ShareType.swift

@@ -16,11 +16,24 @@ import Foundation
 ///           __SPECIAL NOTE__: If you download a PDF, you can view that in a tab. In that case, the URL may have a `file://`
 ///            scheme instead of `http(s)://`, so certain options, like Send to Device / Add to Home Screen, may not be
 ///            available.
-enum ShareType {
+enum ShareType: Equatable, Sendable {
     case file(url: URL, remoteURL: URL?)
     case site(url: URL)
     case tab(url: URL, tab: any ShareTab)
 
+    static func == (lhs: Self, rhs: Self) -> Bool {
+        switch (lhs, rhs) {
+        case let (.file(lhsURL, rhsRemoteURL), .file(rhsURL, lhsRemoteURL)):
+            return lhsURL == rhsURL && rhsRemoteURL == lhsRemoteURL
+        case let (.site(lhsURL), .site(rhsURL)):
+            return lhsURL == rhsURL
+        case let (.tab(lhsURL, lhsTab), .tab(rhsURL, rhsTab)):
+            return lhsURL == rhsURL && lhsTab.tabUUID == rhsTab.tabUUID
+        default:
+            return false
+        }
+    }
+
     /// The share URL wrapped by the given type.
     var wrappedURL: URL {
         switch self {

firefox-ios/Client/TabManagement/Tab.swift

@@ -127,7 +127,10 @@ class Tab: NSObject, ThemeApplicable, FeatureFlaggable, ShareTab {
 
     // Setting default page as topsites
     var newTabPageType: NewTabPage = .topSites
-    var tabUUID: TabUUID = UUID().uuidString
+    // TODO: FXIOS-14381 This can't be nonisolated because it is a var but it is only set once.
+    // We should probably just do this as part of a Tab init from TabData but it will
+    // be a bigger refactor.
+    nonisolated(unsafe) var tabUUID: TabUUID = UUID().uuidString
     private var screenshotUUIDString: String?
 
     var screenshotUUID: UUID? {

firefox-ios/firefox-ios-tests/Tests/ClientTests/Mocks/MockShareTab.swift

@@ -8,6 +8,7 @@ import Foundation
 
 @MainActor
 class MockShareTab: ShareTab {
+    nonisolated let tabUUID: Client.TabUUID
     var canonicalURL: URL?
     var displayTitle: String
     var url: URL?
@@ -18,12 +19,14 @@ class MockShareTab: ShareTab {
         title: String,
         url: URL?,
         canonicalURL: URL?,
+        tabUUID: TabUUID = UUID().uuidString,
         withActiveWebView: Bool = true,
         withTemporaryDocument: TemporaryDocument? = nil
     ) {
         self.displayTitle = title
         self.url = url
         self.canonicalURL = canonicalURL
+        self.tabUUID = tabUUID
         self.webView = TabWebView(frame: CGRect.zero, configuration: .init(), windowUUID: .XCTestDefaultUUID)
         self.temporaryDocument = withTemporaryDocument
     }