Bug 1932829 [wpt PR 49327] - [WebDriver BiDi] Align initial browsingContext events with the spec, a=testonly

Automatic update from web-platform-tests
[WebDriver BiDi] Align initial `browsingContext` events with the spec (#49327)

As discussed in w3c/webdriver-bidi#766, and according to the HTML spec, the navigation, load and dom loaded events should not be emitted when browsing context is created.
--

wpt-commits: 366451632c8d6b555cb3779e622f02bb3c066ec6
wpt-pr: 49327

Author: sadym-chromium

testing/web-platform/tests/webdriver/tests/bidi/browsing_context/dom_content_loaded/dom_content_loaded.py

@@ -1,5 +1,6 @@
 import pytest
 from tests.support.sync import AsyncPoll
+from webdriver.error import TimeoutException
 from webdriver.bidi.modules.script import ContextTarget
 
 from ... import int_interval
@@ -142,22 +143,32 @@ async def on_event(method, data):
 
 
 @pytest.mark.parametrize("type_hint", ["tab", "window"])
-async def test_new_context(bidi_session, subscribe_events, wait_for_event, wait_for_future_safe, type_hint):
+async def test_new_context_not_emitted(bidi_session, subscribe_events,
+      wait_for_event, wait_for_future_safe, type_hint):
     await subscribe_events(events=[DOM_CONTENT_LOADED_EVENT])
 
-    on_entry = wait_for_event(DOM_CONTENT_LOADED_EVENT)
-    new_context = await bidi_session.browsing_context.create(type_hint=type_hint)
-    event = await wait_for_future_safe(on_entry)
+    # Track all received browsingContext.domContentLoaded events in the events array
+    events = []
 
-    assert_navigation_info(
-        event, {"context": new_context["context"], "url": "about:blank"}
+    async def on_event(method, data):
+        events.append(data)
+
+    remove_listener = bidi_session.add_event_listener(
+        DOM_CONTENT_LOADED_EVENT, on_event
     )
-    assert event["navigation"] is not None
+
+    await bidi_session.browsing_context.create(type_hint=type_hint)
+
+    wait = AsyncPoll(bidi_session, timeout=0.5)
+    with pytest.raises(TimeoutException):
+        await wait.until(lambda _: len(events) > 0)
+
+    remove_listener()
 
 
 @pytest.mark.parametrize("sandbox", [None, "sandbox_1"])
 async def test_document_write(
-    bidi_session, subscribe_events, new_tab, wait_for_event, wait_for_future_safe, sandbox
+      bidi_session, subscribe_events, new_tab, wait_for_event, wait_for_future_safe, sandbox
 ):
     await subscribe_events(events=[DOM_CONTENT_LOADED_EVENT])
 

testing/web-platform/tests/webdriver/tests/bidi/browsing_context/load/load.py

@@ -122,17 +122,27 @@ async def on_event(method, data):
 
 
 @pytest.mark.parametrize("type_hint", ["tab", "window"])
-async def test_new_context(bidi_session, subscribe_events, wait_for_event, wait_for_future_safe, type_hint):
+async def test_new_context_not_emitted(bidi_session, subscribe_events,
+      wait_for_event, wait_for_future_safe, type_hint):
     await subscribe_events(events=[CONTEXT_LOAD_EVENT])
 
-    on_entry = wait_for_event(CONTEXT_LOAD_EVENT)
-    new_context = await bidi_session.browsing_context.create(type_hint=type_hint)
-    event = await wait_for_future_safe(on_entry)
+    # Track all received "browsingContext.load" events in the events array
+    events = []
 
-    assert_navigation_info(
-        event, {"context": new_context["context"], "url": "about:blank"}
+    async def on_event(method, data):
+        events.append(data)
+
+    remove_listener = bidi_session.add_event_listener(
+        CONTEXT_LOAD_EVENT, on_event
     )
-    assert event["navigation"] is not None
+
+    await bidi_session.browsing_context.create(type_hint=type_hint)
+
+    wait = AsyncPoll(bidi_session, timeout=0.5)
+    with pytest.raises(TimeoutException):
+        await wait.until(lambda _: len(events) > 0)
+
+    remove_listener()
 
 
 @pytest.mark.parametrize("sandbox", [None, "sandbox_1"])

testing/web-platform/tests/webdriver/tests/bidi/session/subscribe/events.py

@@ -5,7 +5,8 @@
 
 
 @pytest.mark.asyncio
-async def test_subscribe_to_module(bidi_session, subscribe_events, wait_for_event, wait_for_future_safe):
+async def test_subscribe_to_module(bidi_session, subscribe_events, new_tab,
+      wait_for_event, wait_for_future_safe, inline):
     # Subscribe to all browsing context events
     await subscribe_events(events=["browsingContext"])
 
@@ -15,9 +16,6 @@ async def test_subscribe_to_module(bidi_session, subscribe_events, wait_for_even
     async def on_event(method, _):
         events.append(method)
 
-    remove_listener_contextCreated = bidi_session.add_event_listener(
-        "browsingContext.contextCreated", on_event
-    )
     remove_listener_domContentLoaded = bidi_session.add_event_listener(
         "browsingContext.domContentLoaded", on_event
     )
@@ -26,70 +24,78 @@ async def on_event(method, _):
     )
 
     # Wait for the last event
-    on_entry_added = wait_for_event("browsingContext.load")
-    await bidi_session.browsing_context.create(type_hint="tab")
-    await wait_for_future_safe(on_entry_added)
+    on_context_load = wait_for_event("browsingContext.load")
+
+    await bidi_session.browsing_context.navigate(
+        context=new_tab["context"], url=inline("")
+    )
+
+    await wait_for_future_safe(on_context_load)
 
-    assert len(events) == 3
+    # 2 events are expected:
+    # * `browsingContext.domContentLoaded`
+    # * `browsingContext.load`
+    assert len(events) == 2
 
-    remove_listener_contextCreated()
     remove_listener_domContentLoaded()
     remove_listener_load()
 
 
 @pytest.mark.asyncio
 async def test_subscribe_to_one_event_and_then_to_module(
-    bidi_session, subscribe_events, wait_for_event, wait_for_future_safe
+      bidi_session, subscribe_events, wait_for_event, wait_for_future_safe,
+      inline, new_tab
 ):
     # Subscribe to one event
-    await subscribe_events(events=["browsingContext.contextCreated"])
+    await subscribe_events(events=["browsingContext.domContentLoaded"])
 
     # Track all received browsing context events in the events array
     events = []
 
     async def on_event(method, data):
         events.append(method)
 
-    remove_listener_contextCreated = bidi_session.add_event_listener(
-        "browsingContext.contextCreated", on_event
+    remove_listener_domContentLoaded = bidi_session.add_event_listener(
+        "browsingContext.domContentLoaded", on_event
     )
 
-    on_entry_added = wait_for_event("browsingContext.contextCreated")
-    await bidi_session.browsing_context.create(type_hint="tab")
+    on_entry_added = wait_for_event("browsingContext.domContentLoaded")
+    await bidi_session.browsing_context.navigate(
+        context=new_tab["context"], url=inline("")
+    )
     await wait_for_future_safe(on_entry_added)
 
     assert len(events) == 1
-    assert "browsingContext.contextCreated" in events
+    assert "browsingContext.domContentLoaded" in events
 
     # Subscribe to all browsing context events
     await subscribe_events(events=["browsingContext"])
 
     # Clean up the event list
     events = []
 
-    remove_listener_domContentLoaded = bidi_session.add_event_listener(
-        "browsingContext.domContentLoaded", on_event
-    )
     remove_listener_load = bidi_session.add_event_listener(
         "browsingContext.load", on_event
     )
 
     # Wait for the last event
     on_entry_added = wait_for_event("browsingContext.load")
-    await bidi_session.browsing_context.create(type_hint="tab")
+    await bidi_session.browsing_context.navigate(
+        context=new_tab["context"], url=inline("")
+    )
     await wait_for_future_safe(on_entry_added)
 
     # Make sure we didn't receive duplicates
-    assert len(events) == 3
+    assert len(events) == 2
 
-    remove_listener_contextCreated()
     remove_listener_domContentLoaded()
     remove_listener_load()
 
 
 @pytest.mark.asyncio
 async def test_subscribe_to_module_and_then_to_one_event_again(
-    bidi_session, subscribe_events, wait_for_event, wait_for_future_safe
+      bidi_session, subscribe_events, wait_for_event, wait_for_future_safe,
+      new_tab, inline
 ):
     # Subscribe to all browsing context events
     await subscribe_events(events=["browsingContext"])
@@ -100,9 +106,6 @@ async def test_subscribe_to_module_and_then_to_one_event_again(
     async def on_event(method, data):
         events.append(method)
 
-    remove_listener_contextCreated = bidi_session.add_event_listener(
-        "browsingContext.contextCreated", on_event
-    )
     remove_listener_domContentLoaded = bidi_session.add_event_listener(
         "browsingContext.domContentLoaded", on_event
     )
@@ -112,25 +115,28 @@ async def on_event(method, data):
 
     # Wait for the last event
     on_entry_added = wait_for_event("browsingContext.load")
-    await bidi_session.browsing_context.create(type_hint="tab")
+    await bidi_session.browsing_context.navigate(
+        context=new_tab["context"], url=inline("")
+    )
     await wait_for_future_safe(on_entry_added)
 
-    assert len(events) == 3
+    assert len(events) == 2
 
     # Subscribe to one event again
-    await subscribe_events(events=["browsingContext.contextCreated"])
+    await subscribe_events(events=["browsingContext.domContentLoaded"])
 
     # Clean up the event list
     events = []
 
     # Wait for the last event
     on_entry_added = wait_for_event("browsingContext.load")
-    await bidi_session.browsing_context.create(type_hint="tab")
+    await bidi_session.browsing_context.navigate(
+        context=new_tab["context"], url=inline("")
+    )
     await wait_for_future_safe(on_entry_added)
 
     # Make sure we didn't receive duplicates
-    assert len(events) == 3
+    assert len(events) == 2
 
-    remove_listener_contextCreated()
     remove_listener_domContentLoaded()
     remove_listener_load()

testing/web-platform/tests/webdriver/tests/bidi/session/unsubscribe/events.py

@@ -7,7 +7,7 @@
 
 
 @pytest.mark.asyncio
-async def test_unsubscribe_from_module(bidi_session):
+async def test_unsubscribe_from_module(bidi_session, new_tab, inline):
     await bidi_session.session.subscribe(events=["browsingContext"])
     await bidi_session.session.unsubscribe(events=["browsingContext"])
 
@@ -17,45 +17,41 @@ async def test_unsubscribe_from_module(bidi_session):
     async def on_event(method, data):
         events.append(data)
 
-    remove_listener_contextCreated = bidi_session.add_event_listener(
-        "browsingContext.contextCreated", on_event
-    )
     remove_listener_domContentLoaded = bidi_session.add_event_listener(
         "browsingContext.domContentLoaded", on_event
     )
     remove_listener_load = bidi_session.add_event_listener(
         "browsingContext.load", on_event
     )
 
-    await bidi_session.browsing_context.create(type_hint="tab")
+    await bidi_session.browsing_context.navigate(
+        context=new_tab["context"], url=inline("")
+    )
 
     wait = AsyncPoll(bidi_session, timeout=0.5)
     with pytest.raises(TimeoutException):
         await wait.until(lambda _: len(events) > 0)
 
-    remove_listener_contextCreated()
     remove_listener_domContentLoaded()
     remove_listener_load()
 
 
 @pytest.mark.asyncio
 async def test_subscribe_to_module_unsubscribe_from_one_event(
-    bidi_session, wait_for_event, wait_for_future_safe
+      bidi_session, wait_for_event, wait_for_future_safe, new_tab, inline
 ):
     await bidi_session.session.subscribe(events=["browsingContext"])
 
     # Unsubscribe from one event
-    await bidi_session.session.unsubscribe(events=["browsingContext.domContentLoaded"])
+    await bidi_session.session.unsubscribe(
+        events=["browsingContext.domContentLoaded"])
 
     # Track all received browsing context events in the events array
     events = []
 
     async def on_event(method, _):
         events.append(method)
 
-    remove_listener_contextCreated = bidi_session.add_event_listener(
-        "browsingContext.contextCreated", on_event
-    )
     remove_listener_domContentLoaded = bidi_session.add_event_listener(
         "browsingContext.domContentLoaded", on_event
     )
@@ -65,17 +61,17 @@ async def on_event(method, _):
 
     # Wait for the last event
     on_entry_added = wait_for_event("browsingContext.load")
-    await bidi_session.browsing_context.create(type_hint="tab")
+    await bidi_session.browsing_context.navigate(
+        context=new_tab["context"], url=inline("")
+    )
     await wait_for_future_safe(on_entry_added)
 
     # Make sure we didn't receive browsingContext.domContentLoaded event
-    assert len(events) == 2
+    assert len(events) == 1
     assert "browsingContext.domContentLoaded" not in events
 
-    remove_listener_contextCreated()
     remove_listener_domContentLoaded()
     remove_listener_load()
 
     # Unsubscribe from the rest of the events
-    await bidi_session.session.unsubscribe(events=["browsingContext.contextCreated"])
     await bidi_session.session.unsubscribe(events=["browsingContext.load"])