Fix the regex string used to find the chars to normalize with NFKC when searching #20465
Conversation
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/51da5dca2cace1a/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/51da5dca2cace1a/output.txt Total script time: 0.97 mins Published |
|
/botio unittest |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @timvandermeij received. Current queue size: 0 Live output at: http://54.193.163.58:8877/76ff61ba00949dc/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/458261e96b87cbf/output.txt |
timvandermeij
left a comment
timvandermeij
left a comment
There was a problem hiding this comment.
The change itself looks good, but there are quite a few errors in the unit tests.
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/458261e96b87cbf/output.txt Total script time: 20.67 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/76ff61ba00949dc/output.txt Total script time: 25.61 mins
|
|
/botio unittest |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/435d3c17c9372fc/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/0e7237a3d5bd0f7/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/435d3c17c9372fc/output.txt Total script time: 20.74 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/0e7237a3d5bd0f7/output.txt Total script time: 24.47 mins
|
…en searching ICU has been updated in Firefox (see https://bugzilla.mozilla.org/show_bug.cgi?id=2000225). The char `0xA7F1` is now alphabetic and can be normalized as a "S".
calixteman
force-pushed
the
update_char_to_nfkc
branch
from
1eda1b5 to
eee20cf
Compare
|
/botio unittest |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/48ee2ddbd6c469b/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/f0b942009e5c1e8/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/f0b942009e5c1e8/output.txt Total script time: 2.64 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/48ee2ddbd6c469b/output.txt Total script time: 7.97 mins
|
3 participants
ICU has been updated in Firefox (see https://bugzilla.mozilla.org/show_bug.cgi?id=2000225).
The char
0xA7F1is now alphabetic and can be normalized as a "S".