WebGPU NodeMaterial does not takes any params for contruction

[Samsy]

Description

We cannot pass any params to the NodeMaterial, but every other NodeMaterials do

Just wondering if it is something made by design, or something we miss ?

https://github.com/mrdoob/three.js/blob/dev/src/materials/nodes/NodeMaterial.js#L43

[mrdoob]

Lets keep it like this 🙏

[Samsy]

@mrdoob

In the examples, there are a few THREE.NodeMaterial, but the properties can only be set after construction ( does not takes any parameters )

But the MeshBasicNodeMaterial for examples takes in parameters and node directly in it's constructor

It would have been very useful ( depending on the architecture of your project ) to get the same behavior for both and not make any case depending on the nature of the material, especially when extending material with library nodes, unless of course there are some technical reasons things are made that way

[mrdoob]

@sunag @Mugen87 What do you guys think about removing params support from all *NodeMaterials?

[Mugen87]

Sounds good to me!

[Samsy]

Hey there,
I really dont want to bother you in any way and I am really sorry to jump on this again

The current system provides a consistent ( except for the nodematerial ) interface across renderers and material and helps with abstraction

What would be the motivations for removing the params?

[Mugen87]

Avoiding redundancy. Classes like BufferGeometry don't accept parameters in the ctor as well.

Besides, node materials tend to be more composed than earlier material definitions which were mostly configured with flags and primitive values. The ctor approach doesn't work well in that regard.

[mrdoob]

Additionally, the parameters object approach is error prone and... ugly 🙃