R: Fixed some GIF Recording Bugs

Author: Marc Rousavy

Downloads/ImgurSniper.zip

@@ -391,6 +391,7 @@ Falls dieses Problem öfters auftritt, probieren Sie folgendes:
     • Ändern Sie das Bild format von .PNG auf .JPEG
     • Starten Sie Ihren Computer neu
     • Stellen Sie sicher, dass Sie Zugriff auf den Ordner Dokumente/ImgurSniper haben
+    • Achten Sie darauf, dass ein Fehler auftreten kann wenn das GIF zu lang, zu groß, oder zu viele FPS hat!
 Tritt der Fehler immer noch auf, ist Ihre Internet Verbindung möglicherweise
 zu langsam für den Imgur Dienst.</value>
   </data>

Downloads/ImgurSniperSetup.zip

@@ -391,6 +391,7 @@ If this problem occurs more often, try the following:
     • Change the Image Format from .PNG to .JPEG
     • Restart your Computer
     • Make sure that you have Write Permissions to Documents/ImgurSniper
+    • Make sure that your GIF is not too long, too big, or has too many FPS!
 Does the Error still occur? Maybe your Internet Connection
 is too slow for the Imgur Service.</value>
   </data>

ImgurSniper.UI/Properties/strings.Designer.cs

@@ -17,14 +17,16 @@ public partial class GifRecorder {
         private bool _stopped = false;
         private readonly int _fps = FileIO.GifFps;
         private Timer _timer;
+        private Rectangle _size;
+        private TimeSpan _gifLength;
 
         public byte[] Gif;
 
         public GifRecorder(Rectangle size, TimeSpan gifLength) {
             InitializeComponent();
 
-            //Begin Recording
-            Record(size, gifLength);
+            _size = size;
+            _gifLength = gifLength;
 
             Left = size.Left - 2;
             Top = size.Top - 2;
@@ -39,25 +41,33 @@ public GifRecorder(Rectangle size, TimeSpan gifLength) {
             //Space for ProgressBar
             Height += 30;
 
-            BeginAnimation(OpacityProperty, Animations.FadeIn);
+            Loaded += delegate {
+                BeginAnimation(OpacityProperty, Animations.FadeIn);
+                Record();
+            };
         }
 
+
         private void FadeOut(bool result) {
             DoubleAnimation fadeOut = Animations.FadeOut;
             fadeOut.Completed += delegate {
-                DialogResult = result;
+                try {
+                    DialogResult = result;
+                } catch {
+                    Close();
+                }
             };
             BeginAnimation(OpacityProperty, fadeOut);
         }
 
-        private void Record(Rectangle size, TimeSpan duration) {
+        private void Record() {
             try {
                 //Each Frame with TimeStamp
                 List<BitmapFrame> bitmapframes = new List<BitmapFrame>();
 
                 #region Method 1: Timer
                 int currentFrames = 0;
-                int totalFrames = (int)(_fps * (duration.TotalMilliseconds / 1000D));
+                int totalFrames = (int)(_fps * (_gifLength.TotalMilliseconds / 1000D));
                 MemoryStream stream;
                 MemoryStream gifStream = new MemoryStream();
                 // ReSharper disable once PossibleLossOfFraction
@@ -68,39 +78,46 @@ private void Record(Rectangle size, TimeSpan duration) {
                 //Every Frame
                 _timer.Elapsed += delegate {
                     new Thread(() => {
-                        //Finish GIF
-                        if(_stopped || currentFrames >= totalFrames) {
-                            _timer.Stop();
+                        try {
+                            //Finish GIF
+                            if(_stopped || currentFrames >= totalFrames) {
+                                _timer.Stop();
 
-                            GifBitmapEncoder encoder = new GifBitmapEncoder();
-                            foreach(BitmapFrame frame in bitmapframes)
-                                encoder.Frames.Add(frame);
+                                GifBitmapEncoder encoder = new GifBitmapEncoder();
+                                foreach(BitmapFrame frame in bitmapframes)
+                                    encoder.Frames.Add(frame);
 
-                            encoder.Save(gifStream);
+                                encoder.Save(gifStream);
 
-                            Gif = gifStream.ToArray();
+                                Gif = gifStream.ToArray();
 
-                            _timer.Dispose();
-                            return;
-                        }
+                                _timer.Dispose();
+                                return;
+                            }
 
-                        //Add Frames
-                        stream = new MemoryStream();
+                            //Add Frames
+                            stream = new MemoryStream();
 
-                        Screenshot.GetScreenshotWithMouse(size).Save(stream, ImageFormat.Gif);
+                            Screenshot.GetScreenshotWithMouse(_size).Save(stream, ImageFormat.Gif);
 
-                        BitmapFrame bitmap = BitmapFrame.Create(
-                            stream,
-                            BitmapCreateOptions.PreservePixelFormat,
-                            BitmapCacheOption.OnLoad);
+                            BitmapFrame bitmap = BitmapFrame.Create(
+                                stream,
+                                BitmapCreateOptions.PreservePixelFormat,
+                                BitmapCacheOption.OnLoad);
 
-                        bitmapframes.Add(bitmap);
+                            bitmapframes.Add(bitmap);
 
-                        currentFrames++;
+                            currentFrames++;
 
-                        Dispatcher.BeginInvoke(new Action(delegate {
-                            ProgressBar.Value = currentFrames;
-                        }));
+                            Dispatcher.BeginInvoke(new Action(delegate {
+                                ProgressBar.Value = currentFrames;
+                            }));
+                        } catch {
+                            Dispatcher.BeginInvoke(new Action(delegate {
+                                FadeOut(false);
+                                _timer.Stop();
+                            }));
+                        }
                     }).Start();
                 };
 

ImgurSniper.UI/Properties/strings.de.resx

@@ -64,7 +64,11 @@ private void Position(bool allMonitors) {
 
             if(allMonitors) {
                 Rect workArea = SystemParameters.WorkArea;
-                toast.Margin = new Thickness(workArea.Left, workArea.Top, (SystemParameters.VirtualScreenWidth - workArea.Right), (SystemParameters.VirtualScreenHeight - SystemParameters.PrimaryScreenHeight));
+                toast.Margin = new Thickness(
+                    workArea.Left,
+                    workArea.Top,
+                    (SystemParameters.VirtualScreenWidth - workArea.Right),
+                    (SystemParameters.VirtualScreenHeight - SystemParameters.PrimaryScreenHeight));
             }
         }
 
@@ -441,21 +445,20 @@ private void FinishRectangle() {
 
         //Fade out window and shoot cropped screenshot
         private void Complete(int fromX, int fromY, int toX, int toY) {
-            DoubleAnimation anim = new DoubleAnimation(0, TimeSpan.FromSeconds(0.15));
+            DoubleAnimation fadeOut = Animations.FadeOut;
+
+            fadeOut.Completed += async delegate {
+                grid.IsEnabled = false;
+                grid.Visibility = Visibility.Collapsed;
 
-            anim.Completed += async delegate {
-                grid.Opacity = 0;
                 //For render complete
                 Dispatcher.Invoke(new Action(() => { }), DispatcherPriority.ContextIdle, null);
                 await Task.Delay(50);
 
                 Crop(fromX, fromY, toX, toY);
             };
 
-            anim.From = grid.Opacity;
-            anim.To = 0;
-
-            grid.BeginAnimation(OpacityProperty, anim);
+            grid.BeginAnimation(OpacityProperty, fadeOut);
         }
 
         //Make Image from custom Coords
@@ -471,23 +474,22 @@ private void Crop(int fromX, int fromY, int toX, int toY) {
             int w = toX - fromX;
             int h = toY - fromY;
 
-            //The super strange Microsoft Expression Encoder Library only allows numbers dividable by 4
-            //(and only between 4 and 4096)
-            while(w % 4 != 0)
-                w += 1;
-            while(h % 4 != 0)
-                h += 1;
+            //Uncomment if using Microsoft Expression Encoder:
+            ////The super strange Microsoft Expression Encoder Library only allows numbers dividable by 4
+            ////(and only between 4 and 4096)
+            //while(w % 4 != 0)
+            //    w += 1;
+            //while(h % 4 != 0)
+            //    h += 1;
 
             StartGif(new Rectangle(fromX, fromY, w, h));
         }
 
         //"Crop" Rectangle
         private void StartGif(Rectangle size) {
-            int gifLength = FileIO.GifLength;
-
             //Stop recording after 10 Secs
             //CHANGE THIS IF YOU WANT LONGER CAPTURES
-            TimeSpan recordingLength = TimeSpan.FromMilliseconds(5000);
+            TimeSpan recordingLength = TimeSpan.FromMilliseconds(FileIO.GifLength);
 
             GifRecorder recorder = new GifRecorder(size, recordingLength);
             bool? result = recorder.ShowDialog();

ImgurSniper.UI/Properties/strings.resx

@@ -44,7 +44,9 @@ public Notification(string text, NotificationType type, bool autoHide, Action on
             if(onClick != null) {
                 NotificationContent.Cursor = Cursors.Hand;
                 NotificationContent.MouseDown += delegate {
-                    onClick.Invoke();
+                    try {
+                        onClick.Invoke();
+                    } catch { }
                     FadeOut();
                 };
             }

ImgurSniper/GifRecorder.xaml.cs

@@ -203,4 +203,7 @@ Wollen Sie eine detaillierte Fehlermeldung sehen?
   <data name="gif" xml:space="preserve">
     <value>GIF</value>
   </data>
+  <data name="uploadingErrorGif" xml:space="preserve">
+    <value>Beim hochladen des GIFs ist ein Fehler aufgetreten!</value>
+  </data>
 </root>