octo-diff dep rugged fails; fix regression class for no octo-diff

Author: mschuchard

lib/puppet-check/regression_check.rb

@@ -1,29 +1,33 @@
-# temporarily supress warning messages for octocatalog-diff redefining puppet constants and then reactivate
-$VERBOSE = nil
-require 'octocatalog-diff'
-$VERBOSE = false
+begin
+  # temporarily supress warning messages for octocatalog-diff redefining puppet constants and then reactivate
+  $VERBOSE = nil
+  require 'octocatalog-diff'
+  $VERBOSE = false
 
-# executes smoke and regression tests on catalogs
-class RegressionCheck
-  # smoke testing
-  def self.smoke(interface_nodes, octoconfig)
-    options = config(octoconfig)
-    nodes = options.key?(:node) ? [options[:node]] : interface_nodes
-    nodes.each do |node|
-      options[:node] = node
-      OctocatalogDiff::API::V1.catalog(options)
+  # executes smoke and regression tests on catalogs
+  class RegressionCheck
+    # smoke testing
+    def self.smoke(interface_nodes, octoconfig)
+      options = config(octoconfig)
+      nodes = options.key?(:node) ? [options[:node]] : interface_nodes
+      nodes.each do |node|
+        options[:node] = node
+        OctocatalogDiff::API::V1.catalog(options)
+      end
     end
-  end
 
-  # regression testing
-  # def self.regression(nodes, octoconfig)
-  #   options = RegressionCheck.config(octoconfig)
-  #   nodes.each { |node| stuff }
-  # end
+    # regression testing
+    # def self.regression(nodes, octoconfig)
+    #   options = RegressionCheck.config(octoconfig)
+    #   nodes.each { |node| stuff }
+    # end
 
-  # config file loading
-  def self.config(octoconfig)
-    private_class_method :method
-    OctocatalogDiff::API::V1.config(filename: octoconfig)
+    # config file loading
+    def self.config(octoconfig)
+      private_class_method :method
+      OctocatalogDiff::API::V1.config(filename: octoconfig)
+    end
   end
+rescue LoadError
+  # octocatalog-diff not installed
 end

puppet-check.gemspec

@@ -17,7 +17,7 @@ Gem::Specification.new do |spec|
   spec.add_dependency 'reek', '~> 6.0'
   spec.add_dependency 'rubocop', '~> 1.0'
   spec.add_dependency 'rubocop-performance', '~> 1.0'
-  spec.add_development_dependency 'octocatalog-diff', '~> 2.0'
+  # spec.add_development_dependency 'octocatalog-diff', '~> 2.0'
   spec.add_development_dependency 'rake', '~> 13.0'
   spec.add_development_dependency 'rspec', '~> 3.0'
 end