Skip to content

Commit bf0aad0

Browse files
eatonphileatonphil
authored
Elasticsearch scroll fixes (#242)
* Elasticsearch scroll fixes * More ui fixes * Add back tests
1 parent ebacfaa commit bf0aad0

File tree

4 files changed

+214
-159
lines changed

4 files changed

+214
-159
lines changed

‎.github/workflows/pull_requests.yml‎

Lines changed: 129 additions & 129 deletions
Original file line numberDiff line numberDiff line change
@@ -5,135 +5,135 @@ on:
55
branches: [main]
66

77
jobs:
8-
# test:
9-
# runs-on: ubuntu-latest
10-
11-
# steps:
12-
# - uses: actions/checkout@master
13-
# with:
14-
# ref: ${{ github.ref }}
15-
16-
# # FROM: https://github.com/actions/cache/blob/main/examples.md#node---yarn
17-
# - name: Get yarn cache directory path
18-
# id: yarn-cache-dir-path
19-
# run: echo "::set-output name=dir::$(yarn cache dir)"
20-
21-
# - uses: actions/cache@v2
22-
# id: yarn-cache # use this to check for `cache-hit` (`steps.yarn-cache.outputs.cache-hit != 'true'`)
23-
# with:
24-
# path: ${{ steps.yarn-cache-dir-path.outputs.dir }}
25-
# key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }}
26-
# restore-keys: |
27-
# ${{ runner.os }}-yarn-
28-
# - run: ./scripts/ci/prepare_linux.sh --integration-tests
29-
# - run: yarn format
30-
# - run: yarn eslint ui
31-
# - run: yarn tsc
32-
# - run: cd runner && gofmt -w .
33-
# - run: yarn build-language-definitions
34-
# - run: ./scripts/fail_on_diff.sh
35-
# - run: yarn test-licenses
36-
# # Needed so we can have ./build/desktop_runner.js and ./build/go_desktop_runner ready for tests
37-
# - run: yarn build-test-runner
38-
# - run: yarn test --detectOpenHandles --forceExit --verbose
39-
# env:
40-
# AIRTABLE_TOKEN: ${{ secrets.AIRTABLE_TOKEN }}
41-
# AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
42-
# AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
43-
# BIGQUERY_TOKEN: ${{ secrets.BIGQUERY_TOKEN }}
44-
# SNOWFLAKE_USER: ${{ secrets.SNOWFLAKE_USER }}
45-
# SNOWFLAKE_PASSWORD: ${{ secrets.SNOWFLAKE_PASSWORD }}
46-
# SNOWFLAKE_ACCOUNT: ${{ secrets.SNOWFLAKE_ACCOUNT }}
47-
# - run: cd runner && go test -race -coverprofile ../coverage/gounit.cov
48-
# - run: ./runner/scripts/test_coverage.sh
49-
50-
# e2e-linux:
51-
# runs-on: ubuntu-latest
52-
53-
# steps:
54-
# - uses: actions/checkout@master
55-
# with:
56-
# ref: ${{ github.ref }}
57-
58-
# # FROM: https://github.com/actions/cache/blob/main/examples.md#node---yarn
59-
# - name: Get yarn cache directory path
60-
# id: yarn-cache-dir-path
61-
# run: echo "::set-output name=dir::$(yarn cache dir)"
62-
63-
# - uses: actions/cache@v2
64-
# id: yarn-cache # use this to check for `cache-hit` (`steps.yarn-cache.outputs.cache-hit != 'true'`)
65-
# with:
66-
# path: ${{ steps.yarn-cache-dir-path.outputs.dir }}
67-
# key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }}
68-
# restore-keys: |
69-
# ${{ runner.os }}-yarn-
70-
# - run: ./scripts/ci/prepare_linux.sh
71-
# - run: yarn release-desktop 0.0.0-e2etest
72-
# - run: git reset --hard # release blows everything up
73-
# # Set up a virtual framebuffer so Chrome will start
74-
# # https://www.electronjs.org/docs/tutorial/testing-on-headless-ci
75-
# # https://github.com/juliangruber/browser-run/issues/147
76-
# - run: xvfb-run --auto-servernum yarn e2e-test
77-
78-
# e2e-macos:
79-
# runs-on: macos-latest
80-
81-
# steps:
82-
# - uses: actions/checkout@master
83-
# with:
84-
# ref: ${{ github.ref }}
85-
86-
# # FROM: https://github.com/actions/cache/blob/main/examples.md#node---yarn
87-
# - name: Get yarn cache directory path
88-
# id: yarn-cache-dir-path
89-
# run: echo "::set-output name=dir::$(yarn cache dir)"
90-
91-
# - uses: actions/cache@v2
92-
# id: yarn-cache # use this to check for `cache-hit` (`steps.yarn-cache.outputs.cache-hit != 'true'`)
93-
# with:
94-
# path: ${{ steps.yarn-cache-dir-path.outputs.dir }}
95-
# key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }}
96-
# restore-keys: |
97-
# ${{ runner.os }}-yarn-
98-
# - run: ./scripts/ci/prepare_macos.sh
99-
# # Needed so we can have ./build/desktop_runner.js ready for tests
100-
# - run: yarn build-test-runner
101-
# # https://github.com/golang/go/issues/49138 bug in macos -race detector
102-
# - run: MallocNanoZone=0 yarn test --detectOpenHandles --forceExit --verbose shared ui desktop
103-
# - run: cd runner && MallocNanoZone=0 go test -race -cover
104-
# - run: yarn release-desktop 0.0.0-e2etest
105-
# - run: git reset --hard # release blows everything up
106-
# - run: yarn e2e-test
107-
108-
# e2e-windows:
109-
# runs-on: windows-latest
110-
111-
# steps:
112-
# - uses: actions/checkout@master
113-
# with:
114-
# ref: ${{ github.ref }}
115-
116-
# # FROM: https://github.com/actions/cache/blob/main/examples.md#node---yarn
117-
# - name: Get yarn cache directory path
118-
# id: yarn-cache-dir-path
119-
# run: echo "::set-output name=dir::$(yarn cache dir)"
120-
121-
# - uses: actions/cache@v2
122-
# id: yarn-cache # use this to check for `cache-hit` (`steps.yarn-cache.outputs.cache-hit != 'true'`)
123-
# with:
124-
# path: ${{ steps.yarn-cache-dir-path.outputs.dir }}
125-
# key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }}
126-
# restore-keys: |
127-
# ${{ runner.os }}-yarn-
128-
# - run: ./scripts/ci/prepare_windows.ps1
129-
# shell: pwsh
130-
# # Needed so we can have ./build/desktop_runner.js ready for tests
131-
# - run: yarn build-test-runner
132-
# - run: yarn test --detectOpenHandles --forceExit --verbose shared ui desktop
133-
# - run: cd runner && go test -race -cover
134-
# - run: yarn release-desktop 0.0.0-e2etest
135-
# - run: git reset --hard # release blows everything up
136-
# - run: yarn e2e-test
8+
test:
9+
runs-on: ubuntu-latest
10+
11+
steps:
12+
- uses: actions/checkout@master
13+
with:
14+
ref: ${{ github.ref }}
15+
16+
# FROM: https://github.com/actions/cache/blob/main/examples.md#node---yarn
17+
- name: Get yarn cache directory path
18+
id: yarn-cache-dir-path
19+
run: echo "::set-output name=dir::$(yarn cache dir)"
20+
21+
- uses: actions/cache@v2
22+
id: yarn-cache # use this to check for `cache-hit` (`steps.yarn-cache.outputs.cache-hit != 'true'`)
23+
with:
24+
path: ${{ steps.yarn-cache-dir-path.outputs.dir }}
25+
key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }}
26+
restore-keys: |
27+
${{ runner.os }}-yarn-
28+
- run: ./scripts/ci/prepare_linux.sh --integration-tests
29+
- run: yarn format
30+
- run: yarn eslint ui
31+
- run: yarn tsc
32+
- run: cd runner && gofmt -w .
33+
- run: yarn build-language-definitions
34+
- run: ./scripts/fail_on_diff.sh
35+
- run: yarn test-licenses
36+
# Needed so we can have ./build/desktop_runner.js and ./build/go_desktop_runner ready for tests
37+
- run: yarn build-test-runner
38+
- run: yarn test --detectOpenHandles --forceExit --verbose
39+
env:
40+
AIRTABLE_TOKEN: ${{ secrets.AIRTABLE_TOKEN }}
41+
AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
42+
AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
43+
BIGQUERY_TOKEN: ${{ secrets.BIGQUERY_TOKEN }}
44+
SNOWFLAKE_USER: ${{ secrets.SNOWFLAKE_USER }}
45+
SNOWFLAKE_PASSWORD: ${{ secrets.SNOWFLAKE_PASSWORD }}
46+
SNOWFLAKE_ACCOUNT: ${{ secrets.SNOWFLAKE_ACCOUNT }}
47+
- run: cd runner && go test -race -coverprofile ../coverage/gounit.cov
48+
- run: ./runner/scripts/test_coverage.sh
49+
50+
e2e-linux:
51+
runs-on: ubuntu-latest
52+
53+
steps:
54+
- uses: actions/checkout@master
55+
with:
56+
ref: ${{ github.ref }}
57+
58+
# FROM: https://github.com/actions/cache/blob/main/examples.md#node---yarn
59+
- name: Get yarn cache directory path
60+
id: yarn-cache-dir-path
61+
run: echo "::set-output name=dir::$(yarn cache dir)"
62+
63+
- uses: actions/cache@v2
64+
id: yarn-cache # use this to check for `cache-hit` (`steps.yarn-cache.outputs.cache-hit != 'true'`)
65+
with:
66+
path: ${{ steps.yarn-cache-dir-path.outputs.dir }}
67+
key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }}
68+
restore-keys: |
69+
${{ runner.os }}-yarn-
70+
- run: ./scripts/ci/prepare_linux.sh
71+
- run: yarn release-desktop 0.0.0-e2etest
72+
- run: git reset --hard # release blows everything up
73+
# Set up a virtual framebuffer so Chrome will start
74+
# https://www.electronjs.org/docs/tutorial/testing-on-headless-ci
75+
# https://github.com/juliangruber/browser-run/issues/147
76+
- run: xvfb-run --auto-servernum yarn e2e-test
77+
78+
e2e-macos:
79+
runs-on: macos-latest
80+
81+
steps:
82+
- uses: actions/checkout@master
83+
with:
84+
ref: ${{ github.ref }}
85+
86+
# FROM: https://github.com/actions/cache/blob/main/examples.md#node---yarn
87+
- name: Get yarn cache directory path
88+
id: yarn-cache-dir-path
89+
run: echo "::set-output name=dir::$(yarn cache dir)"
90+
91+
- uses: actions/cache@v2
92+
id: yarn-cache # use this to check for `cache-hit` (`steps.yarn-cache.outputs.cache-hit != 'true'`)
93+
with:
94+
path: ${{ steps.yarn-cache-dir-path.outputs.dir }}
95+
key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }}
96+
restore-keys: |
97+
${{ runner.os }}-yarn-
98+
- run: ./scripts/ci/prepare_macos.sh
99+
# Needed so we can have ./build/desktop_runner.js ready for tests
100+
- run: yarn build-test-runner
101+
# https://github.com/golang/go/issues/49138 bug in macos -race detector
102+
- run: MallocNanoZone=0 yarn test --detectOpenHandles --forceExit --verbose shared ui desktop
103+
- run: cd runner && MallocNanoZone=0 go test -race -cover
104+
- run: yarn release-desktop 0.0.0-e2etest
105+
- run: git reset --hard # release blows everything up
106+
- run: yarn e2e-test
107+
108+
e2e-windows:
109+
runs-on: windows-latest
110+
111+
steps:
112+
- uses: actions/checkout@master
113+
with:
114+
ref: ${{ github.ref }}
115+
116+
# FROM: https://github.com/actions/cache/blob/main/examples.md#node---yarn
117+
- name: Get yarn cache directory path
118+
id: yarn-cache-dir-path
119+
run: echo "::set-output name=dir::$(yarn cache dir)"
120+
121+
- uses: actions/cache@v2
122+
id: yarn-cache # use this to check for `cache-hit` (`steps.yarn-cache.outputs.cache-hit != 'true'`)
123+
with:
124+
path: ${{ steps.yarn-cache-dir-path.outputs.dir }}
125+
key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }}
126+
restore-keys: |
127+
${{ runner.os }}-yarn-
128+
- run: ./scripts/ci/prepare_windows.ps1
129+
shell: pwsh
130+
# Needed so we can have ./build/desktop_runner.js ready for tests
131+
- run: yarn build-test-runner
132+
- run: yarn test --detectOpenHandles --forceExit --verbose shared ui desktop
133+
- run: cd runner && go test -race -cover
134+
- run: yarn release-desktop 0.0.0-e2etest
135+
- run: git reset --hard # release blows everything up
136+
- run: yarn e2e-test
137137

138138
test-server:
139139
runs-on: ubuntu-latest

0 commit comments

Comments
 (0)