-
Notifications
You must be signed in to change notification settings - Fork 320
feat: Implement user transports #3707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
rklaehn
wants to merge
30
commits into
feat-bind-interfaces
Choose a base branch
from
feat-user-transport
base: feat-bind-interfaces
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Reexport guts of magicsock for implementing custom transports - Add comments to new public fields and structs
packets are being sent and received, but we still get a timeout connecting
It's got its own subnet [0, 3] so we can go back from an IPV6 addr to a UserMappedAddr
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/3707/docs/iroh/ Last updated: 2025-11-28T12:05:11Z |
c792b95 to
5eea792
Compare
a7a4e2c to
e6b3aab
Compare
479652f to
232524f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds user defined transports.
Transports have to impl a dynable trait, currently named UserTransport. Implementing this requires implementing another dynable trait UserSender. Creating a transport requires implementing yet another dynable trait UserTransportConfig (possibly to be renamed to UserTransportFactory?, it's not a config).
An user addr is just an opaque blob with an u64 tranport id. Small blobs will be inlined, but that is an implementation detail.
Breaking Changes
Notes & open questions
Open questions:
Change checklist
quic-rpciroh-gossipiroh-blobsdumbpipesendme