test(Guardrail Node): Add Guardrail tests #21388
Merged
+1,905
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 10 files
Prompt for AI agents (all 1 issues)
Understand the root cause of the following 1 issues and fix them.
<file name="packages/@n8n/nodes-langchain/nodes/Guardrails/test/helpers/model.test.ts">
<violation number="1" location="packages/@n8n/nodes-langchain/nodes/Guardrails/test/helpers/model.test.ts:105">
`runLLMValidation` now expects the input text followed by a config object, but the test still passes positional arguments. This will throw before the helper runs and makes the test fail.</violation>
</file>
React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.
| .mocked((await import('langchain/agents')).AgentExecutor) | ||
| .mockImplementation(() => mockAgentExecutor as unknown as AgentExecutor); | ||
|
|
||
| const result = await runLLMValidation( |
There was a problem hiding this comment.
runLLMValidation now expects the input text followed by a config object, but the test still passes positional arguments. This will throw before the helper runs and makes the test fail.
Prompt for AI agents
Address the following comment on packages/@n8n/nodes-langchain/nodes/Guardrails/test/helpers/model.test.ts at line 105:
<comment>`runLLMValidation` now expects the input text followed by a config object, but the test still passes positional arguments. This will throw before the helper runs and makes the test fail.</comment>
<file context>
@@ -0,0 +1,151 @@
+ .mocked((await import('langchain/agents')).AgentExecutor)
+ .mockImplementation(() => mockAgentExecutor as unknown as AgentExecutor);
+
+ const result = await runLLMValidation(
+ 'test-guardrail',
+ mockModel,
</file context>
|
E2E Tests: n8n tests passed after 7m 45s Run Details
Groups
This message was posted automatically by
currents.dev | Integration Settings
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds unit tests to the new Guardrails node
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/NODE-3797/write-tests-for-guardrail-node
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)