fix: Fix insights query date range calculation in backend #21409
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
n8n-assistant
bot
added
core
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Started to move the Insights service logic tests in here so that the integration test could be simplified but only got time to do it for the getInsightsSummary
| } else { | ||
| // Calculate the date range (minimum 1 day) for previous period | ||
| const dateRangeInDays = Math.max(1, daysDiff); | ||
| const dateRangeInDays = daysDiff + 1; |
There was a problem hiding this comment.
This was actually compensating for the mistake done with the default date but then it broke the other requests 😅
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
…tion-is-incorrect
…tion-is-incorrect
guillaumejacquart
left a comment
guillaumejacquart
left a comment
There was a problem hiding this comment.
Numbers are good now on my side
| if (!query.startDate) { | ||
| return { | ||
| startDate: DateTime.now().minus({ days: 7 }).toJSDate(), | ||
| startDate: DateTime.now().minus({ days: 6 }).toJSDate(), |
There was a problem hiding this comment.
Might just be worth adding a comment here to explain why we take 6 instead of 7 by default
|
E2E Tests: n8n tests timed out after 30m Run Details
Groups
This message was posted automatically by
currents.dev | Integration Settings
|
ireneea
deleted the
pay-4052-insights-query-date-range-calculation-is-incorrect
branch
|
Got released with |
Summary
Related Linear tickets, Github issues, and Community forum posts
fixes PAY-4052
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)