Do not use InetSocketAddress.createUnresolved for uris already containing an IP address

bartosz822 · bartosz822 · commit 465b0e6d262a · 2025-10-30T17:44:14.000+01:00
diff --git a/src/main/java/io/nats/client/impl/SocketDataPort.java b/src/main/java/io/nats/client/impl/SocketDataPort.java
@@ -74,7 +74,7 @@ public void connect(@NonNull NatsConnection conn, @NonNull NatsUri nuri, long ti
                 socket = connectToFastestIp(options, host, port, (int) timeout);
             } else {
                 socket = createSocket(options);
-                InetSocketAddress inetSocketAddress = options.isNoResolveHostnames() ?
+                InetSocketAddress inetSocketAddress = (options.isNoResolveHostnames() && !nuri.hostIsIpAddress()) ?
                         InetSocketAddress.createUnresolved(host, port) : new InetSocketAddress(host, port);
                 socket.connect(inetSocketAddress, (int) timeout);
             }

Original file line number	Diff line number	Diff line change
`@@ -74,7 +74,7 @@ public void connect(@NonNull NatsConnection conn, @NonNull NatsUri nuri, long ti`
`74`	`74`	`socket = connectToFastestIp(options, host, port, (int) timeout);`
`75`	`75`	`} else {`
`76`	`76`	`socket = createSocket(options);`
`77`		`- InetSocketAddress inetSocketAddress = options.isNoResolveHostnames() ?`
	`77`	`+ InetSocketAddress inetSocketAddress = (options.isNoResolveHostnames() && !nuri.hostIsIpAddress()) ?`
`78`	`78`	`InetSocketAddress.createUnresolved(host, port) : new InetSocketAddress(host, port);`
`79`	`79`	`socket.connect(inetSocketAddress, (int) timeout);`
`80`	`80`	`}`