Skip to content

Commit eff47e5

Browse files
committed
chore: Sikre mot injections ved manipulering av environment variable
1 parent 4954cc5 commit eff47e5

File tree

2 files changed

+18
-3
lines changed

2 files changed

+18
-3
lines changed

.github/workflows/createRelease.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,8 @@ jobs:
3232
GH_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
3333
SCOPE: ${{ github.repository_owner }}
3434
PATH_TO_CONFIG_FILE: "config/releaseConfig.yml"
35-
RELEASE_NAME: "sf-platform"
35+
RELEASE_NAME_PREFIX: ${{ vars.RELEASE_NAME_PREFIX || 'sf' }}
36+
RELEASE_NAME: ""
3637
GIT_REF: ${{ inputs.gitRef || github.sha }}
3738
BRANCH_NAME: ${{ github.ref_name }}
3839
WORKITEM_FILTER: ${{ vars.WORKITEM_FILTER || 'PTCRM-[0-9]' }}
@@ -42,7 +43,7 @@ jobs:
4243
- name: Set Release Name
4344
id: createReleaseName
4445
run: |
45-
echo "RELEASE_NAME=sf-platform_$(date +%s%3N)" >> "$GITHUB_ENV"
46+
echo "RELEASE_NAME=${{ env.RELEASE_NAME_PREFIX }}_$(date +%s%3N)" >> "$GITHUB_ENV"
4647
4748
- name: Authenticate Node
4849
uses: actions/setup-node@v4

.github/workflows/release.yml

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ jobs:
3030
SCOPE: ${{ github.repository_owner }}
3131
REPO: ${{ github.repository }}
3232
RELEASE_TAG: ${{ inputs.release_tag }}
33+
RELEASE_NAME_PREFIX: ${{ vars.RELEASE_NAME_PREFIX || 'sf' }}
3334
steps:
3435
- name: Authenticate Node
3536
uses: actions/setup-node@v4
@@ -61,7 +62,20 @@ jobs:
6162
-H "X-GitHub-Api-Version: 2022-11-28" \
6263
https://api.github.com/repos/${REPO}/releases/latest \
6364
| jq -r '.tag_name')
64-
echo "RELEASE_TAG=$latest_tag" >> $GITHUB_ENV
65+
66+
echo "Latest release tag: $latest_tag"
67+
68+
if [ -z "$latest_tag" ]; then
69+
echo "::error::No latest release found for repository ${REPO}"
70+
exit 1
71+
fi
72+
73+
if [[ ! "$latest_tag" =~ ^$RELEASE_NAME_PREFIX_[0-9]{13,14}$ ]]; then
74+
echo "::error::Invalid release name format: $latest_tag. Expected format: $RELEASE_NAME_PREFIX_<timestamp>"
75+
exit 1
76+
fi
77+
78+
echo "RELEASE_TAG=$(echo "$latest_tag" | tr -d '\n')" >> $GITHUB_ENV
6579
fi
6680
6781
- name: Checkout

0 commit comments

Comments
 (0)