improve _version_check_greater to be more universal in netbox_utils

- allow compare even 3 digit versions or more
- sanitize inputs - full_version can sometimes be 4.2.9-Docker-3.2.1
  just use only 4.2.9
- extend unit tests

Author: cernymi

changelogs/fragments/netbox_version_check_greater.yml

@@ -0,0 +1,3 @@
+---
+minor_changes:
+  - improve version_check_greater to be more universal

plugins/module_utils/netbox_utils.py

@@ -808,32 +808,24 @@ def _version_sanitize(raw_value: str) -> str:
             f"Invalid version {raw_value!r}: must start with a digit (e.g. '1', '2.5', '4.2.9')"
         )
 
-    def _version_check_greater(self, greater, lesser, greater_or_equal=False):
+    def _version_check_greater(
+        self, ver_net: str, ver_def: str, greater_or_equal=False
+    ) -> bool:
         """Determine if first argument is greater than second argument.
 
         Args:
-            greater (str): decimal string
-            lesser (str): decimal string
+            ver_net (str): decimal string
+            ver_def (str): decimal string
         """
-        g_major, g_minor = greater.split(".")
-        l_major, l_minor = lesser.split(".")
-
-        # convert to ints
-        g_major = int(g_major)
-        g_minor = int(g_minor)
-        l_major = int(l_major)
-        l_minor = int(l_minor)
-
-        # If major version is higher then return true right off the bat
-        if g_major > l_major:
-            return True
-        elif greater_or_equal and g_major == l_major and g_minor >= l_minor:
-            return True
-        # If major versions are equal, and minor version is higher, return True
-        elif g_major == l_major and g_minor > l_minor:
-            return True
-
-        return False
+        t_net = tuple(int(x) for x in self._version_sanitize(ver_net).split("."))
+        t_def = tuple(int(x) for x in self._version_sanitize(ver_def).split("."))
+
+        # Pad shorter tuple with zeros
+        max_len = max(len(t_net), len(t_def))
+        t_net += (0,) * (max_len - len(t_net))
+        t_def += (0,) * (max_len - len(t_def))
+
+        return t_net > t_def if not greater_or_equal else t_net >= t_def
 
     def _connect_netbox_api(self, url, token, ssl_verify, cert, headers=None):
         try:

tests/unit/module_utils/test_netbox_base_class.py

@@ -375,24 +375,29 @@ def test_update_netbox_object_with_changes_check_mode_true(
     assert diff == on_update_diff
 
 
-@pytest.mark.parametrize("version", ["2.9", "2.8", "2.7"])
+@pytest.mark.parametrize("version", ["2.13", "2.12", "2.11", "2.10.8", "2.10"])
 def test_version_check_greater_true(mock_netbox_module, nb_obj_mock, version):
     mock_netbox_module.nb_object = nb_obj_mock
-    assert mock_netbox_module._version_check_greater("2.10", version)
+    assert mock_netbox_module._version_check_greater(version, "2.9")
+    assert mock_netbox_module._version_check_greater(version, "2.9.11")
 
 
-@pytest.mark.parametrize("version", ["2.13", "2.12", "2.11", "2.10"])
+@pytest.mark.parametrize("version", ["2.9", "2.8", "2.7.12", "2.7"])
 def test_version_check_greater_false(mock_netbox_module, nb_obj_mock, version):
     mock_netbox_module.nb_object = nb_obj_mock
-    assert not mock_netbox_module._version_check_greater("2.10", version)
+    assert not mock_netbox_module._version_check_greater(version, "2.10")
+    assert not mock_netbox_module._version_check_greater(version, "2.10.8")
 
 
-@pytest.mark.parametrize("version", ["2.9", "2.8", "2.7"])
+@pytest.mark.parametrize("version", ["2.9", "2.8", "2.7.5", "2.7"])
 def test_version_check_greater_equal_to_true(mock_netbox_module, nb_obj_mock, version):
     mock_netbox_module.nb_object = nb_obj_mock
     assert mock_netbox_module._version_check_greater(
         version, "2.7", greater_or_equal=True
     )
+    assert mock_netbox_module._version_check_greater(
+        version, "2.6.12", greater_or_equal=True
+    )
 
 
 @pytest.mark.parametrize("version", ["2.6", "2.5", "2.4"])
@@ -401,6 +406,9 @@ def test_version_check_greater_equal_to_false(mock_netbox_module, nb_obj_mock, v
     assert not mock_netbox_module._version_check_greater(
         version, "2.7", greater_or_equal=True
     )
+    assert not mock_netbox_module._version_check_greater(
+        version, "2.7.7", greater_or_equal=True
+    )
 
 
 @pytest.mark.parametrize(