chore: add editor config

chore: reuse commands

Author: saw-jan

.editorconfig

@@ -0,0 +1,23 @@
+root = true
+
+[*]
+charset = utf-8
+end_of_line = lf
+insert_final_newline = true
+indent_style = tab
+indent_size = 4
+trim_trailing_whitespace = true
+
+[package*.json]
+indent_size = 2
+indent_style = space
+
+[*.md]
+trim_trailing_whitespace = false
+
+[*.svg]
+insert_final_newline = false
+
+[*.{yml,yaml}]
+indent_size = 2
+indent_style = space

.eslintrc.js

@@ -1,17 +1,17 @@
 module.exports = {
 	globals: {
-		appVersion: true
+		appVersion: true,
 	},
 	parserOptions: {
-		requireConfigFile: false
+		requireConfigFile: false,
 	},
-	extends: [
-		'@nextcloud'
-	],
+	extends: ['@nextcloud'],
 	rules: {
 		'jsdoc/require-jsdoc': 'off',
 		'jsdoc/tag-lines': 'off',
 		'vue/first-attribute-linebreak': 'off',
-		'import/extensions': 'off'
-	}
+		'import/extensions': 'off',
+		'max-len': ['error', { code: 120 }],
+	},
+	ignorePatterns: ['node_modules/*', 'js/*', 'vendor/*', 'dev/apps/*', 'l10n/*'],
 }

jest.config.js

@@ -1,6 +1,3 @@
-const path = require('path')
-const rootDir = path.resolve(__dirname, '../../../')
-
 module.exports = {
 	testMatch: ['**/tests/**/*.spec.{js,ts}'],
 	moduleNameMapper: {
@@ -10,6 +7,7 @@ module.exports = {
 	transform: {
 		// process *.vue files with vue-jest
 		'\\.vue$': '@vue/vue2-jest',
+		// eslint-disable-next-line max-len
 		'.+\\.(css|styl|less|sass|scss|jpg|jpeg|png|svg|gif|eot|otf|webp|ttf|woff|woff2|mp4|webm|wav|mp3|m4a|aac|oga|avif)$':
 			'jest-transform-stub',
 		'\\.c?js$': 'babel-jest',

package.json

@@ -9,11 +9,11 @@
   "scripts": {
     "build": "NODE_ENV=production webpack --progress --config webpack.js",
     "dev": "NODE_ENV=development webpack --progress --config webpack.js",
-    "watch": "NODE_ENV=development webpack --progress --watch --config webpack.js",
+    "watch": "npm run dev -- --watch",
     "lint": "eslint --ext .js,.vue src tests",
-    "lint:fix": "eslint --ext .js,.vue src tests --fix",
+    "lint:fix": "npm run lint -- --fix",
     "stylelint": "stylelint css src",
-    "stylelint:fix": "stylelint css src --fix",
+    "stylelint:fix": "npm run stylelint -- --fix",
     "test:unit": "jest --silent",
     "test:unit:watch": "jest --watch --no-coverage"
   },

src/adminSettings.js

@@ -15,10 +15,10 @@ import Vue from 'vue'
 import './bootstrap.js'
 import AdminSettings from './components/AdminSettings.vue'
 
-// eslint-disable-next-line
+// eslint-disable-next-line no-unused-expressions
 'use strict'
 
-// eslint-disable-next-line
+// eslint-disable-next-line no-new
 new Vue({
 	el: '#openproject_prefs',
 	render: h => h(AdminSettings),

src/personalSettings.js

@@ -15,10 +15,10 @@ import Vue from 'vue'
 import './bootstrap.js'
 import PersonalSettings from './components/PersonalSettings.vue'
 
-// eslint-disable-next-line
+// eslint-disable-next-line no-unused-expressions
 'use strict'
 
-// eslint-disable-next-line
+// eslint-disable-next-line no-new
 new Vue({
 	el: '#openproject_prefs',
 	render: h => h(PersonalSettings),

src/reference.js

@@ -30,7 +30,9 @@ __webpack_public_path__ = OC.linkTo('integration_openproject', 'js/') // eslint-
 registerWidget('integration_openproject_work_package', async (el, { richObjectType, richObject, accessible }) => {
 	// here we lazy load the components so it does not slow down the initial page load
 	const { default: Vue } = await import(/* webpackChunkName: "reference-wp-lazy" */'vue')
-	const { default: WorkPackageReferenceWidget } = await import(/* webpackChunkName: "reference-wp-lazy" */'./views/WorkPackageReferenceWidget.vue')
+	const { default: WorkPackageReferenceWidget } = await import(
+		/* webpackChunkName: "reference-wp-lazy" */'./views/WorkPackageReferenceWidget.vue'
+	)
 	Vue.mixin({ methods: { t, n } })
 	const Widget = Vue.extend(WorkPackageReferenceWidget)
 	new Widget({
@@ -44,7 +46,8 @@ registerWidget('integration_openproject_work_package', async (el, { richObjectTy
 
 registerCustomPickerElement('openproject-work-package-ref', async (el, { providerId, accessible }) => {
 	const { default: Vue } = await import(/* webpackChunkName: "reference-picker-lazy" */'vue')
-	const { default: WorkPackagePickerElement } = await import(/* webpackChunkName: "reference-picker-lazy" */'./views/WorkPackagePickerElement.vue')
+	const { default: WorkPackagePickerElement } = await import(
+		/* webpackChunkName: "reference-picker-lazy" */'./views/WorkPackagePickerElement.vue')
 	Vue.mixin({ methods: { t, n } })
 
 	const Element = Vue.extend(WorkPackagePickerElement)

src/utils.js

@@ -56,8 +56,14 @@ export const WORKPACKAGES_SEARCH_ORIGIN = {
 	LINK_MULTIPLE_FILES_MODAL: 'link-multiple-files-modal',
 }
 export const USER_SETTINGS = {
-	NAVIGATION_LINK_DESCRIPTION: t('integration_openproject', 'Displays a link to your OpenProject instance in the Nextcloud header.'),
-	UNIFIED_SEARCH_DESCRIPTION: t('integration_openproject', 'Allows you to search OpenProject work packages via the universal search bar in Nextcloud.'),
+	NAVIGATION_LINK_DESCRIPTION: t(
+		'integration_openproject',
+		'Displays a link to your OpenProject instance in the Nextcloud header.',
+	),
+	UNIFIED_SEARCH_DESCRIPTION: t(
+		'integration_openproject',
+		'Allows you to search OpenProject work packages via the universal search bar in Nextcloud.',
+	),
 }
 
 export const NO_OPTION_TEXT_STATE = {

stylelint.config.js

@@ -3,6 +3,6 @@ stylelintConfig.rules = {
 	...stylelintConfig.rules,
 	'declaration-colon-space-after': 'always',
 	'max-empty-lines': 1,
-	"block-opening-brace-space-before": "always"
+	'block-opening-brace-space-before': 'always',
 }
 module.exports = stylelintConfig

tests/jest/views/LinkMultipleFilesModal.spec.js

@@ -161,11 +161,14 @@ describe('LinkMultipleFilesModal.vue', () => {
 		beforeEach(() => {
 			wrapper = mountWrapper()
 		})
-		it.each([STATE.NO_TOKEN, STATE.ERROR, STATE.OK])('shows the empty message when state is other than loading', async (state) => {
-			await wrapper.setData({ state })
-			await localVue.nextTick()
-			expect(wrapper.find(emptyContentSelector).exists()).toBeTruthy()
-		})
+		it.each([STATE.NO_TOKEN, STATE.ERROR, STATE.OK])(
+			'shows the empty message when state is other than loading',
+			async (state) => {
+				await wrapper.setData({ state })
+				await localVue.nextTick()
+				expect(wrapper.find(emptyContentSelector).exists()).toBeTruthy()
+			},
+		)
 
 		it('shows message "Add a new link to all selected files" when admin config is okay', async () => {
 			wrapper = mount(LinkMultipleFilesModal, {