update to go1.25, node24, golangci-lint v2, trixie (#483)

Considered pinning `gopls` again, but we want to be relatively up-to-date so figured I'd update things. I'm sure there's a better way to manage the node version, but this gets updated less than yearly so I'm not worried about it.

Made a few tweaks to satisfy golangci-lint but nothing significant.

fixes #482

Author: ryepup

.devcontainer/devcontainer.json

@@ -4,7 +4,7 @@
   "build": {
     "dockerfile": "../tools/devtools/Dockerfile",
     "args": {
-      "BASE_IMG": "mcr.microsoft.com/devcontainers/typescript-node:18-bullseye"
+      "BASE_IMG": "mcr.microsoft.com/devcontainers/typescript-node:24-trixie"
     }
   },
   "postCreateCommand": "sudo find . -name node_modules -exec chown node:node {} \\;",

.github/workflows/examples-autocomplete.yml

@@ -2,10 +2,10 @@ name: builds the autocomplete example usage of reference-lib
 on:
   push:
     branches: ['main']
-    paths: ['examples/autocomplete/**', 'reference-lib/**']
+    paths: ['examples/autocomplete/**', '.github/workflows/examples-autocomplete.yml', 'reference-lib/**']
   pull_request:
     branches: ['main']
-    paths: ['examples/autocomplete/**', 'reference-lib/**']
+    paths: ['examples/autocomplete/**', '.github/workflows/examples-autocomplete.yml', 'reference-lib/**']
 
 defaults:
   run:
@@ -18,6 +18,8 @@ jobs:
     steps:
       - uses: actions/checkout@v5
       - uses: actions/setup-node@v6
+        with:
+          node-version: 24
       - name: build the reference-lib
         working-directory: ./reference-lib
         run: |

.github/workflows/examples-ref-browser.yml

@@ -2,10 +2,10 @@ name: builds the example ref-browser usage of reference-lib
 on:
   push:
     branches: ['main']
-    paths: ['examples/ref-browser/**', 'reference-lib/**']
+    paths: ['examples/ref-browser/**', '.github/workflows/examples-ref-browser.yml', 'reference-lib/**']
   pull_request:
     branches: ['main']
-    paths: ['examples/ref-browser/**', 'reference-lib/**']
+    paths: ['examples/ref-browser/**', '.github/workflows/examples-ref-browser.yml', 'reference-lib/**']
 
 defaults:
   run:
@@ -18,6 +18,8 @@ jobs:
     steps:
       - uses: actions/checkout@v5
       - uses: actions/setup-node@v6
+        with:
+          node-version: 24
       - name: build the reference-lib
         working-directory: ./reference-lib
         run: |

.github/workflows/reference-converter.daily.yml

@@ -32,6 +32,8 @@ jobs:
         fi
 
     - uses: actions/setup-node@v6
+      with:
+        node-version: 24
     - name: update npm package version
       if: steps.diff.outputs.reference_change
       run: npm version patch --no-git-tag-version

.github/workflows/reference-converter.yml

@@ -51,7 +51,7 @@ jobs:
           cache: false
       - name: use the same version of GOLANGCI_LINT_VERSION as devtools
         run: make devtools-versions >> "$GITHUB_ENV"
-      - uses: golangci/golangci-lint-action@v6
+      - uses: golangci/golangci-lint-action@v9
         with:
           working-directory: ${{ env.working-directory }}
           version: v${{ env.GOLANGCI_LINT_VERSION }}

.github/workflows/reference-lib.publish.yml

@@ -19,8 +19,8 @@ jobs:
       - uses: actions/checkout@v5
       - uses: actions/setup-node@v6
         with:
-          node-version: '16.x'
           registry-url: 'https://registry.npmjs.org'
+          node-version: 24
       - name: Install dependencies
         run: npm ci
       - name: Test it out

.golangci.yml

@@ -1,5 +1,6 @@
+version: "2"
 linters:
-  # add non-default linters https://golangci-lint.run/usage/linters/#disabled-by-default
+  # add non-default linters https://golangci-lint.run/docs/linters/
   enable:
     - bodyclose
     - errorlint

reference-converter/go.mod

@@ -1,6 +1,6 @@
 module github.com/nginxinc/nginx-directive-reference/reference-converter
 
-go 1.24
+go 1.25
 
 require (
 	github.com/gomarkdown/markdown v0.0.0-20241205020045-f7e15b2f3e62

reference-converter/internal/atom/atom.go

@@ -47,7 +47,7 @@ func openURL(ctx context.Context, url string, client http.Client) ([]byte, error
 	if err != nil {
 		return nil, fmt.Errorf("unable to download %s: %w", url, err)
 	}
-	defer res.Body.Close()
+	defer res.Body.Close() //nolint:errcheck // nothing to do about it
 
 	if res.StatusCode != http.StatusOK {
 		return nil, fmt.Errorf("unable to download %s: %s", url, res.Status)

reference-converter/internal/parse/link.go

@@ -35,7 +35,7 @@ func (l *link) UnmarshalXML(d *xml.Decoder, start xml.StartElement) error {
 		title = p.Name
 	}
 
-	title = strings.Replace(title, "\n", " ", -1)
+	title = strings.ReplaceAll(title, "\n", " ")
 
 	href := attrs["url"]
 	if href == "" {