Review: Read mock CRD objects via a YAML declaration

Author: mrajagopal

pkg/mock/mock_data_collector.go

@@ -1,6 +1,7 @@
 package mock
 
 import (
+	"embed"
 	"io"
 	"log"
 	"testing"
@@ -22,8 +23,12 @@ import (
 	"k8s.io/client-go/rest"
 	metricsfake "k8s.io/metrics/pkg/client/clientset/versioned/fake"
 	"k8s.io/utils/ptr"
+	"sigs.k8s.io/yaml"
 )
 
+//go:embed testdata/crds.yaml
+var testDataFS embed.FS
+
 func SetupMockDataCollector(t *testing.T) *data_collector.DataCollector {
 	t.Helper()
 
@@ -70,27 +75,15 @@ func SetupMockDataCollector(t *testing.T) *data_collector.DataCollector {
 		Host: "https://mock-k8s-server",
 	}
 
-	// Create a CRD clientset (using the real clientset, but not actually connecting)
-	crd := &apiextensionsv1.CustomResourceDefinition{
-		ObjectMeta: metav1.ObjectMeta{
-			Name: "testcrd.example.com",
-		},
-		Spec: apiextensionsv1.CustomResourceDefinitionSpec{
-			Group: "example.com",
-			Names: apiextensionsv1.CustomResourceDefinitionNames{
-				Kind:     "TestCRD",
-				Plural:   "testcrds",
-				Singular: "testcrd",
-			},
-			Scope: apiextensionsv1.NamespaceScoped,
-			Versions: []apiextensionsv1.CustomResourceDefinitionVersion{
-				{
-					Name:    "v1",
-					Served:  true,
-					Storage: true,
-				},
-			},
-		},
+	// Use embedded file
+	data, err := testDataFS.ReadFile("testdata/crds.yaml")
+	if err != nil {
+		t.Fatalf("failed to read embedded testdata/crds.yaml: %v", err)
+	}
+
+	crd := &apiextensionsv1.CustomResourceDefinition{}
+	if err := yaml.Unmarshal(data, crd); err != nil {
+		t.Fatalf("failed to unmarshal CRD from testdata/crds.yaml: %v", err)
 	}
 
 	crdClient := apiextensionsfake.NewClientset(crd)
@@ -100,8 +93,6 @@ func SetupMockDataCollector(t *testing.T) *data_collector.DataCollector {
 	defer ctrl.Finish()
 	helmClient := mockHelmClient.NewMockClient(ctrl)
 
-
-
 	helmClient.EXPECT().GetSettings().Return(&cli.EnvSettings{}).AnyTimes()
 	var mockedRelease = release.Release{
 		Name:      "test",

pkg/mock/testdata/crds.yaml

@@ -0,0 +1,23 @@
+apiVersion: apiextensions.k8s.io/v1
+kind: CustomResourceDefinition
+metadata:
+  name: testcrd.example.com
+spec:
+  group: example.com
+  names:
+    kind: TestCRD
+    plural: testcrds
+    singular: testcrd
+  scope: Namespaced
+  versions:
+  - name: v1
+    served: true
+    storage: true
+    schema:
+      openAPIV3Schema:
+        type: object
+        properties:
+          spec:
+            type: object
+          status:
+            type: object