Fixed dead store assignment in r.subrequest().

xeioex · xeioex · commit 8759db7458f5 · 2024-10-14T16:51:54.000-07:00
Found by Clang static analyzer.
diff --git a/nginx/ngx_http_js_module.c b/nginx/ngx_http_js_module.c
@@ -3474,7 +3474,6 @@ ngx_http_js_ext_subrequest(njs_vm_t *vm, njs_value_t *args, njs_uint_t nargs,
         return NJS_ERROR;
     }
 
-    promise = 0;
     flags = NGX_HTTP_SUBREQUEST_BACKGROUND;
 
     njs_value_undefined_set(retval);
@@ -5859,7 +5858,6 @@ ngx_http_qjs_ext_subrequest(JSContext *cx, JSValueConst this_val,
                                      "exclusive");
     }
 
-    promise = 0;
     retval = JS_UNDEFINED;
     flags = NGX_HTTP_SUBREQUEST_BACKGROUND;
 

Original file line number	Diff line number	Diff line change
`@@ -3474,7 +3474,6 @@ ngx_http_js_ext_subrequest(njs_vm_t vm, njs_value_t args, njs_uint_t nargs,`
`3474`	`3474`	`return NJS_ERROR;`
`3475`	`3475`	`}`
`3476`	`3476`
`3477`		`- promise = 0;`
`3478`	`3477`	`flags = NGX_HTTP_SUBREQUEST_BACKGROUND;`
`3479`	`3478`
`3480`	`3479`	`njs_value_undefined_set(retval);`
`@@ -5859,7 +5858,6 @@ ngx_http_qjs_ext_subrequest(JSContext *cx, JSValueConst this_val,`
`5859`	`5858`	`"exclusive");`
`5860`	`5859`	`}`
`5861`	`5860`
`5862`		`- promise = 0;`
`5863`	`5861`	`retval = JS_UNDEFINED;`
`5864`	`5862`	`flags = NGX_HTTP_SUBREQUEST_BACKGROUND;`
`5865`	`5863`