Skip to content

fixes #18081; fixes #18079; fixes #18080; nested ref/deref'd types #24335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Araq merged 12 commits into from
Oct 25, 2024
Merged

fixes #18081; fixes #18079; fixes #18080; nested ref/deref'd types #24335

Araq merged 12 commits into from
Oct 25, 2024

Conversation

@ringabout
Copy link
Member

@ringabout ringabout commented Oct 21, 2024 •
edited
Loading

fixes #18081;
fixes #18080
fixes #18079

reverts #20738

It is probably more reasonable to use the type node from nkObjConstr since it is barely changed unlike the external type, which is susceptible to code transformation e.g. addr(deref objconstr).

@ringabout ringabout marked this pull request as draft October 21, 2024 15:36
@ringabout
Copy link
Member Author

ringabout commented Oct 21, 2024 •
edited
Loading

I will check tranf instead. Or add a specific checking for isRef like or e[0].typ.skipTypes.kind == tyRef

ringabout
ringabout commented Oct 22, 2024
View reviewed changes
@ringabout ringabout marked this pull request as ready for review October 22, 2024 01:01
@ringabout ringabout marked this pull request as draft October 22, 2024 01:02
@ringabout ringabout changed the title fixes #18081; fixes #18079; nested ref/deref'd types fixes #18081; fixes #18079; fixes #18080; nested ref/deref'd types Oct 22, 2024
@ringabout

This comment was marked as outdated.

Sign in to view
@ringabout ringabout closed this Oct 22, 2024
@ringabout ringabout reopened this Oct 22, 2024
@ringabout ringabout marked this pull request as ready for review October 22, 2024 15:04
@ringabout ringabout mentioned this pull request Oct 22, 2024
Closed
@Araq Araq merged commit aa90d00 into devel Oct 25, 2024
22 checks passed
@Araq Araq deleted the pr_ref_new branch October 25, 2024 20:36
@github-actions
Copy link
Contributor

github-actions bot commented Oct 25, 2024

Thanks for your hard work on this PR!
The lines below are statistics of the Nim compiler built from aa90d00

Hint: mm: orc; opt: speed; options: -d:release
175657 lines; 8.652s; 654.809MiB peakmem

narimiran pushed a commit that referenced this pull request Dec 20, 2024
@ringabout @narimiran
fixes #18081; fixes #18079; fixes #18080; nested ref/deref'd types (#…
5fb4662 
…24335)

fixes #18081;
fixes #18080
fixes #18079

reverts #20738

It is probably more reasonable to use the type node from `nkObjConstr`
since it is barely changed unlike the external type, which is
susceptible to code transformation e.g. `addr(deref objconstr)`.

(cherry picked from commit aa90d00)
narimiran pushed a commit that referenced this pull request Jan 14, 2025
@ringabout @narimiran
fixes #18081; fixes #18079; fixes #18080; nested ref/deref'd types (#…
98403a0 
…24335)

fixes #18081;
fixes #18080
fixes #18079

reverts #20738

It is probably more reasonable to use the type node from `nkObjConstr`
since it is barely changed unlike the external type, which is
susceptible to code transformation e.g. `addr(deref objconstr)`.

(cherry picked from commit aa90d00)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

3 participants

@ringabout @Araq