Skip to content

Commit 032bd7e

Browse files
committed
[#10] Update accessing dependencies on LoginViewModel
1 parent 52b3dca commit 032bd7e

File tree

1 file changed

+6
-8
lines changed

1 file changed

+6
-8
lines changed

lib/screens/login/login_view_model.dart

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,6 @@ final loginViewModelProvider =
1111
AsyncNotifierProvider.autoDispose<LoginViewModel, void>(LoginViewModel.new);
1212

1313
class LoginViewModel extends AutoDisposeAsyncNotifier<void> {
14-
late LoginUseCase loginUseCase;
15-
late InternetConnectionManager internetConnectionManager;
16-
1714
bool isValidEmail(String? email) {
1815
// Just use a simple rule, no fancy Regex!
1916
return !(email == null || !email.contains('@'));
@@ -28,7 +25,6 @@ class LoginViewModel extends AutoDisposeAsyncNotifier<void> {
2825
required String password,
2926
}) async {
3027
state = const AsyncLoading();
31-
3228
final loginUseCase = ref.read(loginUseCaseProvider);
3329
final result = await loginUseCase(
3430
LoginParams(
@@ -37,9 +33,7 @@ class LoginViewModel extends AutoDisposeAsyncNotifier<void> {
3733
),
3834
);
3935

40-
if (result is Success) {
41-
state = const AsyncData(null);
42-
} else if (result is Failed) {
36+
if (result is Failed) {
4337
final error = result as Failed;
4438
final exception = error.exception.actualException as NetworkExceptions;
4539

@@ -64,11 +58,15 @@ class LoginViewModel extends AutoDisposeAsyncNotifier<void> {
6458
AppError.generic,
6559
StackTrace.empty,
6660
);
61+
return;
6762
}
63+
64+
state = const AsyncData(null);
6865
}
6966

7067
Future<bool> _hasInternetConnection() async {
71-
internetConnectionManager = ref.read(internetConnectionManagerProvider);
68+
final internetConnectionManager =
69+
ref.read(internetConnectionManagerProvider);
7270
return await internetConnectionManager.hasConnection();
7371
}
7472

0 commit comments

Comments
 (0)