Skip to content

Commit 60d439e

Browse files
authored
ci: update Node.js versions in tests (#1686)
* ci: update Node.js versions in tests Use maintenance and current Node.js versions in CI workflows. * chore: add define to skip experimental warning Define NODE_API_EXPERIMENTAL_NO_WARNING in tests when NAPI_EXPERIMENTAL is set.
1 parent d0845b3 commit 60d439e

File tree

3 files changed

+12
-3
lines changed

3 files changed

+12
-3
lines changed

.github/workflows/ci-win.yml

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,13 +18,21 @@ jobs:
1818
- standard
1919
- experimental
2020
node-version:
21-
- 18.x
2221
- 20.x
2322
- 22.x
23+
- 24.x
24+
- 25.x
2425
architecture: [x64, x86]
2526
os:
2627
- windows-2022
2728
- windows-2025
29+
exclude:
30+
# Skip when node 24.x or 25.x AND architecture is x86 since there is
31+
# no published Node.js x86 build for those versions.
32+
- node-version: 24.x
33+
architecture: x86
34+
- node-version: 25.x
35+
architecture: x86
2836
runs-on: ${{ matrix.os }}
2937
steps:
3038
- name: Harden Runner

.github/workflows/ci.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,10 @@ jobs:
1818
- standard
1919
- experimental
2020
node-version:
21-
- 18.x
2221
- 20.x
2322
- 22.x
23+
- 24.x
24+
- 25.x
2425
os:
2526
- macos-latest
2627
- ubuntu-latest

common.gypi

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
},
66
'conditions': [
77
['NAPI_VERSION!=""', { 'defines': ['NAPI_VERSION=<@(NAPI_VERSION)'] } ],
8-
['NAPI_VERSION==2147483647', { 'defines': ['NAPI_EXPERIMENTAL'] } ],
8+
['NAPI_VERSION==2147483647', { 'defines': ['NAPI_EXPERIMENTAL', 'NODE_API_EXPERIMENTAL_NO_WARNING'] } ],
99
['disable_deprecated=="true"', {
1010
'defines': ['NODE_ADDON_API_DISABLE_DEPRECATED']
1111
}],

0 commit comments

Comments
 (0)