Added traffic plugin support #549
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CendioOssman
requested changes
Feb 28, 2023
Member
CendioOssman
left a comment
CendioOssman
left a comment
There was a problem hiding this comment.
I can understand the use case here, but I'm a bit cautious about where we draw the line of what should be included in this project.
So far, we've stayed very agnostic about what kind of traffic flows through websockify.
|
|
||
| def from_target(self, s): | ||
| self.target_packet_count += 1 | ||
| if self.target_packet_count == 2 and b"\x02" in s[1:]: # check if password is supported |
Member
There was a problem hiding this comment.
I'm afraid this is a bit fragile. There is no guarantee that the stream will be split in packages in a specific way.
Some rudimentary protocol handling will be needed here.
Have you considered a proxy model, instead of this filtering model? It might be a better fit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to use the this project together with noVNC to allow our customers/qa to connect to vnc devices(linux) on our private networks. I do not want them to know/enter passwords, but the devices have passwords configured. The traffic plugin system allows me to intercept the authentication and handle it differently.
The example implementation takes a password provided by the JSONTokenApi
--traffic-plugin websockify.plugins.VncTokenAuthenticationTrafficPlugin --token-plugin JSONTokenApi --token-source https://someapie/verify?token=%sThe API should respond with
{ "host": "localhost", "port": 5902, "password": "vncpassword" }