Skip to content

Commit 08ae2e6

Browse files
authored
MRG: Merge pull request #26 from octue/fix-artifact-addresses
Add new repository name to artifact addresses
2 parents 2a0f7da + 63d65d0 commit 08ae2e6

File tree

5 files changed

+14
-12
lines changed

5 files changed

+14
-12
lines changed

.github/workflows/test.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ jobs:
8383
- name: Check `image_latest_artifact`
8484
uses: nick-fields/assert-action@v1
8585
with:
86-
expected: europe-west6-docker.pkg.dev/my-test-project/my-affix/my-test-service:refs-pull-${{ github.event.number }}-mer-latest
86+
expected: europe-west6-docker.pkg.dev/my-test-project/octue-twined-services/my-affix/my-test-service:refs-pull-${{ github.event.number }}-mer-latest
8787
actual: ${{ steps.get-deployment-info.outputs.image_latest_artifact }}
8888

8989
- name: Check `image_latest_tag`
@@ -95,7 +95,7 @@ jobs:
9595
- name: Check `image_version_artifact`
9696
uses: nick-fields/assert-action@v1
9797
with:
98-
expected: europe-west6-docker.pkg.dev/my-test-project/my-affix/my-test-service:refs-pull-${{ github.event.number }}-mer
98+
expected: europe-west6-docker.pkg.dev/my-test-project/octue-twined-services/my-affix/my-test-service:refs-pull-${{ github.event.number }}-mer
9999
actual: ${{ steps.get-deployment-info.outputs.image_version_artifact }}
100100

101101
- name: Check `image_version_tag`
@@ -107,7 +107,7 @@ jobs:
107107
- name: Check `image_default_artifact`
108108
uses: nick-fields/assert-action@v1
109109
with:
110-
expected: europe-west6-docker.pkg.dev/my-test-project/my-affix/my-test-service:default
110+
expected: europe-west6-docker.pkg.dev/my-test-project/octue-twined-services/my-affix/my-test-service:default
111111
actual: ${{ steps.get-deployment-info.outputs.image_default_artifact }}
112112

113113
- name: Check `short_sha`

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ steps:
2525

2626
- name: Get deployment info
2727
id: get-deployment-info
28-
uses: octue/[email protected].0
28+
uses: octue/[email protected].1
2929
with:
3030
gcp_project_name: test-project
3131
gcp_project_number: 1234

action.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ outputs:
6363

6464
runs:
6565
using: "docker"
66-
image: "docker://octue/get-deployment-info:0.4.0"
66+
image: "docker://octue/get-deployment-info:0.4.1"
6767
args:
6868
- ${{ inputs.gcp_project_name }}
6969
- ${{ inputs.gcp_project_number }}

entrypoint.sh

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
#!/bin/sh -l
2+
ARTIFACT_REGISTRY_REPOSITORY=octue-twined-services
3+
24
# Get inputs
3-
GCP_PROJECT_NAME=$1
5+
GCP_PROJECT_ID=$1
46
GCP_PROJECT_NUMBER=$2
57
GCP_REGION=$3
68
GCP_RESOURCE_AFFIX=$4
@@ -17,7 +19,7 @@ VERSION_SLUG=$(echo $VERSION | tr . -)
1719
echo "version_slug=$VERSION_SLUG" >> $GITHUB_OUTPUT
1820

1921
# Get GCP variables.
20-
echo "gcp_project_name=$GCP_PROJECT_NAME" >> $GITHUB_OUTPUT
22+
echo "gcp_project_name=$GCP_PROJECT_ID" >> $GITHUB_OUTPUT
2123
echo "gcp_project_number=$GCP_PROJECT_NUMBER" >> $GITHUB_OUTPUT
2224
echo "gcp_region=$GCP_REGION" >> $GITHUB_OUTPUT
2325
echo "gcp_resource_affix=$GCP_RESOURCE_AFFIX" >> $GITHUB_OUTPUT
@@ -57,13 +59,13 @@ REVISION_TAG_SLUG=$(echo $REVISION_TAG | tr . -)
5759
echo "revision_tag_slug=$REVISION_TAG_SLUG" >> $GITHUB_OUTPUT
5860

5961
# Set image artifact addresses.
60-
IMAGE_VERSION_ARTIFACT="$GCP_REGION-docker.pkg.dev/$GCP_PROJECT_NAME/$GCP_RESOURCE_AFFIX/$GCP_SERVICE_NAME:$IMAGE_VERSION_TAG"
62+
IMAGE_VERSION_ARTIFACT="$GCP_REGION-docker.pkg.dev/$GCP_PROJECT_ID/$ARTIFACT_REGISTRY_REPOSITORY/$GCP_RESOURCE_AFFIX/$GCP_SERVICE_NAME:$IMAGE_VERSION_TAG"
6163
echo "image_version_artifact=$IMAGE_VERSION_ARTIFACT" >> $GITHUB_OUTPUT
6264

63-
IMAGE_LATEST_ARTIFACT="$GCP_REGION-docker.pkg.dev/$GCP_PROJECT_NAME/$GCP_RESOURCE_AFFIX/$GCP_SERVICE_NAME:$IMAGE_LATEST_TAG"
65+
IMAGE_LATEST_ARTIFACT="$GCP_REGION-docker.pkg.dev/$GCP_PROJECT_ID/$ARTIFACT_REGISTRY_REPOSITORY/$GCP_RESOURCE_AFFIX/$GCP_SERVICE_NAME:$IMAGE_LATEST_TAG"
6466
echo "image_latest_artifact=$IMAGE_LATEST_ARTIFACT" >> $GITHUB_OUTPUT
6567

66-
IMAGE_DEFAULT_ARTIFACT="$GCP_REGION-docker.pkg.dev/$GCP_PROJECT_NAME/$GCP_RESOURCE_AFFIX/$GCP_SERVICE_NAME:default"
68+
IMAGE_DEFAULT_ARTIFACT="$GCP_REGION-docker.pkg.dev/$GCP_PROJECT_ID/$ARTIFACT_REGISTRY_REPOSITORY/$GCP_RESOURCE_AFFIX/$GCP_SERVICE_NAME:default"
6769
echo "image_default_artifact=$IMAGE_DEFAULT_ARTIFACT" >> $GITHUB_OUTPUT
6870

6971

@@ -83,7 +85,7 @@ echo "- version: $VERSION"
8385
echo "- version_slug: $VERSION_SLUG"
8486
echo "- revision_tag: $REVISION_TAG"
8587
echo "- revision_tag_slug: $REVISION_TAG_SLUG"
86-
echo "- gcp_project_name: $GCP_PROJECT_NAME"
88+
echo "- gcp_project_name: $GCP_PROJECT_ID"
8789
echo "- gcp_project_number: $GCP_PROJECT_NUMBER"
8890
echo "- gcp_region: $GCP_REGION"
8991
echo "- gcp_resource_affix: $GCP_RESOURCE_AFFIX"

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
[tool.poetry]
22
name = "get-deployment-info"
3-
version = "0.4.0"
3+
version = "0.4.1"
44
description = "A Github Action that gets the information required to build and deploy an Octue service."
55
authors = ["Marcus Lugg <[email protected]>"]
66
readme = "README.md"

0 commit comments

Comments
 (0)