Skip to content

Commit 3ac2bce

Browse files
authored
DEVOPS-27: Temporarily pin setup-envtest to Go 1.24 version (#3622)
## Description Some CI are failing like https://github.com/odigos-io/odigos/actions/runs/18466376700/job/52609233046?pr=3610#step:6:97 ``` mkdir -p /home/runner/work/odigos/odigos/instrumentor/bin GOBIN=/home/runner/work/odigos/odigos/instrumentor/bin go install sigs.k8s.io/controller-runtime/tools/setup-envtest@latest go: downloading sigs.k8s.io/controller-runtime/tools/setup-envtest v0.0.0-20251013122658-1ad089b0ee87 go: downloading sigs.k8s.io/controller-runtime v0.22.3 go: sigs.k8s.io/controller-runtime/tools/setup-envtest@latest: sigs.k8s.io/controller-runtime/tools/[email protected] requires go >= 1.25.0 (running go 1.24.0; GOTOOLCHAIN=local) make: *** [Makefile:67: /home/runner/work/odigos/odigos/instrumentor/bin/setup-envtest] Error 1 ``` This started because controller-runtime bumped setup-envtest to 1.25 yesterday and we check it out from latest kubernetes-sigs/controller-runtime#3349 This pins the tool to the most recent commit without including the 1.25 bump ## How Has This Been Tested? <!-- Describe the tests you ran and how you verified your changes. --> - [ ] Added Unit Tests - [ ] Updated e2e Tests - [ ] Manual Testing - [ ] Manual Load Test ## Kubernetes Checklist <!-- If this PR affects how Odigos interacts with Kubernetes, check the relevant boxes below and provide more details --> - [ ] Changes how Odigos interacts with Kubernetes - [ ] Introduces additional calls to the API Server (potential performance impact) - [ ] New Query/feature supported in all the k8s versions supported by Odigos - [ ] Modifies Odigos manifests (addressed in both CLI and Helm) - [ ] Changes RBAC permissions ## User Facing Changes <!-- Any changes that users will notice or need to be aware of --> - [ ] Users need to take action before upgrading - [ ] Automatic migration will modify existing objects (backward compatible) - [ ] Changes UI, CLI, or K8s Manifests aspects in a way that users need to be aware of - [ ] Documentation updated accordingly
1 parent b3b51d4 commit 3ac2bce

File tree

4 files changed

+4
-4
lines changed

4 files changed

+4
-4
lines changed

api/Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@ $(CONTROLLER_GEN): $(LOCALBIN)
105105
.PHONY: envtest
106106
envtest: $(ENVTEST) ## Download envtest-setup locally if necessary.
107107
$(ENVTEST): $(LOCALBIN)
108-
GOBIN=$(LOCALBIN) go install sigs.k8s.io/controller-runtime/tools/setup-envtest@latest
108+
GOBIN=$(LOCALBIN) go install sigs.k8s.io/controller-runtime/tools/setup-envtest@3e8b2594ffc4811fc59888a3edab739e3e222e25 # temporarily pinned to 1.24
109109

110110
.PHONY: generate-client
111111
generate-client:

autoscaler/Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ $(CONTROLLER_GEN): $(LOCALBIN)
129129
.PHONY: envtest
130130
envtest: $(ENVTEST) ## Download envtest-setup locally if necessary.
131131
$(ENVTEST): $(LOCALBIN)
132-
GOBIN=$(LOCALBIN) go install sigs.k8s.io/controller-runtime/tools/setup-envtest@latest
132+
GOBIN=$(LOCALBIN) go install sigs.k8s.io/controller-runtime/tools/setup-envtest@3e8b2594ffc4811fc59888a3edab739e3e222e25 # temporarily pinned to 1.24
133133

134134
.PHONY: go-licenses
135135
go-licenses: $(LOCALBIN)

instrumentor/Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ ENVTEST ?= $(LOCALBIN)/setup-envtest
6464
.PHONY: envtest
6565
envtest: $(ENVTEST) ## Download envtest-setup locally if necessary.
6666
$(ENVTEST): $(LOCALBIN)
67-
GOBIN=$(LOCALBIN) go install sigs.k8s.io/controller-runtime/tools/setup-envtest@latest
67+
GOBIN=$(LOCALBIN) go install sigs.k8s.io/controller-runtime/tools/setup-envtest@3e8b2594ffc4811fc59888a3edab739e3e222e25 # temporarily pinned to 1.24
6868

6969
.PHONY: go-licenses
7070
go-licenses: $(LOCALBIN)

scheduler/Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ $(CONTROLLER_GEN): $(LOCALBIN)
129129
.PHONY: envtest
130130
envtest: $(ENVTEST) ## Download envtest-setup locally if necessary.
131131
$(ENVTEST): $(LOCALBIN)
132-
GOBIN=$(LOCALBIN) go install sigs.k8s.io/controller-runtime/tools/setup-envtest@latest
132+
GOBIN=$(LOCALBIN) go install sigs.k8s.io/controller-runtime/tools/setup-envtest@3e8b2594ffc4811fc59888a3edab739e3e222e25 # temporarily pinned to 1.24
133133

134134
.PHONY: go-licenses
135135
go-licenses: $(LOCALBIN)

0 commit comments

Comments
 (0)