store account id in gcdata

Author: howardchung

json/1781962623_gcdata.json

@@ -2,60 +2,70 @@
   "match_id": 1781962623,
   "players": [
     {
+      "account_id": 120269134,
       "player_slot": 0,
       "party_id": 0,
       "permanent_buffs": [],
       "party_size": 10
     },
     {
+      "account_id": 109378329,
       "player_slot": 1,
       "party_id": 0,
       "permanent_buffs": [],
       "party_size": 10
     },
     {
+      "account_id": 122866507,
       "player_slot": 2,
       "party_id": 0,
       "permanent_buffs": [],
       "party_size": 10
     },
     {
+      "account_id": 195471601,
       "player_slot": 3,
       "party_id": 0,
       "permanent_buffs": [],
       "party_size": 10
     },
     {
+      "account_id": 17120336,
       "player_slot": 4,
       "party_id": 0,
       "permanent_buffs": [],
       "party_size": 10
     },
     {
+      "account_id": 44152866,
       "player_slot": 128,
       "party_id": 0,
       "permanent_buffs": [],
       "party_size": 10
     },
     {
+      "account_id": 80319669,
       "player_slot": 129,
       "party_id": 0,
       "permanent_buffs": [],
       "party_size": 10
     },
     {
+      "account_id": 235274000,
       "player_slot": 130,
       "party_id": 0,
       "permanent_buffs": [],
       "party_size": 10
     },
     {
+      "account_id": 106823512,
       "player_slot": 131,
       "party_id": 0,
       "permanent_buffs": [],
       "party_size": 10
     },
     {
+      "account_id": 86751979,
       "player_slot": 132,
       "party_id": 0,
       "permanent_buffs": [],

json/1781962623_playercache_api_0.json

@@ -27,6 +27,7 @@
   "cluster": 132,
   "lobby_type": 7,
   "game_mode": 22,
+  "average_rank": 81,
   "heroes": {
     "0": {
       "account_id": 120269134,

json/1781962623_playercache_gcdata_0.json

@@ -1,7 +1,7 @@
 {
+  "account_id": 120269134,
   "player_slot": 0,
   "party_size": 10,
   "match_id": 1781962623,
-  "cluster": 132,
-  "account_id": 120269134
+  "cluster": 132
 }

store/getGcData.ts

@@ -95,12 +95,9 @@ async function saveGcData(
   );
   const players = data.match.players.map(
     (p: any, i: number): GcPlayer => ({
-      // NOTE: account ids are not anonymous in this call so we don't include it in the data to insert
-      // TODO We could start storing this data but then the API also needs to respect the user's match history setting
-      // If we just enable this alone we'll write partial rows with only gcdata to the player_caches table
-      // Fix: in upsertPlayerCaches force only reading account_id from pgroup, not the match object itself
+      // NOTE: account ids are not anonymous in this call
       // Also, we probably want to queue a job post-parse that reads back the match data and updates all player_caches now that we have identity and parsed data
-      // account_id: p.account_id,
+      account_id: p.account_id,
       player_slot: p.player_slot,
       party_id: Number(p.party_id),
       permanent_buffs: p.permanent_buffs ?? [],

store/insert.ts

@@ -343,7 +343,7 @@ export async function insertMatch(
     await Promise.all(
       copy.players.map(async (p) => {
         // add account id to each player so we know what caches to update
-        const account_id = pgroup[p.player_slot]?.account_id ?? p.account_id;
+        const account_id = pgroup[p.player_slot]?.account_id;
         // join player with match to form player_match
         const playerMatch: Partial<ParsedPlayerMatch> = {
           ...p,