add some notes

Author: howardchung

store/getGcData.ts

@@ -96,7 +96,9 @@ async function saveGcData(
   const players = data.match.players.map(
     (p: any, i: number): GcPlayer => ({
       // NOTE: account ids are not anonymous in this call
-      // Also, we probably want to queue a job post-parse that reads back the match data and updates all player_caches now that we have identity and parsed data
+      // Also, we probably want to queue a reconciliation job post-parse
+      // to read back the match data and update all player_caches now that we have identity and parsed data
+      // Maybe also want to do it after GC, and call it from fullhistory to update on request?
       account_id: p.account_id,
       player_slot: p.player_slot,
       party_id: Number(p.party_id),

svc/fullhistory.ts

@@ -30,10 +30,12 @@ async function updatePlayer(player: FullHistoryJob) {
 }
 
 async function processMatch(matchId: string) {
-  const container = generateJob('api_details', {
-    match_id: Number(matchId),
-  });
   // Disabled due to Steam GetMatchDetails being broken
+  // This would update the match blob with the visibility and update player caches to make them show up under a player
+  // Could possibly queue these matches for GC data fetch and then trigger a reconciliation from our own DB (similar to proposed change after parsing a match)
+  // const container = generateJob('api_details', {
+  //   match_id: Number(matchId),
+  // });
   // const body = await getSteamAPIData({ url: container.url, noRetry: true });
   // const match = body.result;
   // await insertMatch(match, {