Skip to content

Commit 81b7c95

Browse files
authored
Merge branch 'main' into type_annotation
2 parents 6975821 + 3b72fbb commit 81b7c95

File tree

10 files changed

+86
-81
lines changed

10 files changed

+86
-81
lines changed

.github/workflows/audit.yml

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,5 +27,8 @@ jobs:
2727
inputs: requirements.txt docs/requirements.txt
2828

2929
- name: Check Secrets SDK Vulnerabilities
30-
working-directory: src/secrets
31-
run: cargo audit --deny warnings --ignore RUSTSEC-2024-0370 --ignore RUSTSEC-2024-0429
30+
uses: actions-rust-lang/audit@v1
31+
with:
32+
denyWarnings: true
33+
ignore: RUSTSEC-2024-0370,RUSTSEC-2024-0429
34+
workingDirectory: src/secrets

.github/workflows/sdk-build.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ jobs:
1212
strategy:
1313
fail-fast: false
1414
matrix:
15-
os: [ubuntu-latest, macos-latest, windows-latest]
15+
os: [ubuntu-22.04, macos-latest, windows-latest]
1616
python-version: ["3.9", "3.10", "3.11", "3.12", "3.13"]
1717
env:
1818
OS: ${{ matrix.os }}
@@ -33,7 +33,7 @@ jobs:
3333
- name: Lint with pydoclint
3434
run: pydoclint --exclude='.*/(build|response)/.*' src
3535
- name: Lint with pylint
36-
run: |
36+
run: |
3737
# check for Python errors
3838
pylint src --errors-only --disable=E0401,E0611 --ignore=build
3939
# check for lint

.github/workflows/sdk-release.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ on:
1414

1515
jobs:
1616
release:
17-
runs-on: ubuntu-latest
17+
runs-on: ubuntu-22.04
1818
permissions:
1919
contents: write
2020
issues: write

.github/workflows/secrets-sdk.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,14 +7,15 @@ name: Secrets SDK CI
77

88
on:
99
push:
10-
branches: ["**"]
10+
branches: ["main"]
1111
paths:
1212
- "src/secrets/**"
1313
- ".github/workflows/secrets-sdk.yml"
1414
tags: ["**"]
1515
pull_request:
1616
paths:
1717
- "src/secrets/**"
18+
- ".github/workflows/secrets-sdk.yml"
1819
workflow_dispatch:
1920
concurrency:
2021
group: ${{ github.workflow }}-${{ github.ref }}
@@ -71,10 +72,9 @@ jobs:
7172
steps:
7273
- uses: actions/checkout@v4
7374
- uses: actions/setup-python@v5
74-
if: ${{ matrix.target != 'aarch64' }}
7575
with:
7676
python-version: "3.10"
77-
architecture: ${{ matrix.target }}
77+
architecture: ${{ matrix.target == 'aarch64' && 'x64' || matrix.target }}
7878
- name: Build wheels
7979
uses: PyO3/maturin-action@v1
8080
with:

CHANGELOG.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,12 @@
22

33
All notable changes to the Zowe Client Python SDK will be documented in this file.
44

5+
## Recent Changes
6+
7+
### Bug Fixes
8+
9+
- Updated the `pyo3` dependency of the Secrets SDK for technical currency. [#355](https://github.com/zowe/zowe-client-python-sdk/pull/355)
10+
511
## `1.0.0-dev22`
612

713
## Recent Changes

pyproject.toml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
[build-system]
2+
requires = ["setuptools", "wheel"]
3+
build-backend = "setuptools.build_meta"
4+
15
[tool.black]
26
line-length = 120
37

requirements.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ PyYAML==6.0.1
55
requests==2.32.0
66

77
# Dev deps
8+
setuptools
89
black
910
coverage
1011
isort

src/secrets/Cargo.lock

Lines changed: 61 additions & 70 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/secrets/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,5 +11,5 @@ name = "keyring"
1111
crate-type = ["cdylib"]
1212

1313
[dependencies]
14-
pyo3 = { version = "0.20.0", features = ["abi3-py37"] }
14+
pyo3 = { version = "0.24.1", features = ["abi3-py37", "generate-import-lib"] }
1515
secrets_core = { git = "https://github.com/zowe/zowe-cli.git", branch = "master" }

src/secrets/src/lib.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,14 +40,14 @@ fn find_password(service: String) -> PyResult<Option<String>> {
4040
fn find_credentials(service: String) -> PyResult<Vec<(String, String)>> {
4141
let mut creds: Vec<(String, String)> = vec![];
4242
match os::find_credentials(&service, &mut creds) {
43-
Ok(res) => Ok(creds),
43+
Ok(_res) => Ok(creds),
4444
Err(e) => Err(PyValueError::new_err(format!("{:#?}", e))),
4545
}
4646
}
4747

4848
/// A Python module implemented in Rust.
4949
#[pymodule]
50-
fn keyring(_py: Python, m: &PyModule) -> PyResult<()> {
50+
fn keyring(_py: Python, m: &Bound<'_, PyModule>) -> PyResult<()> {
5151
m.add_function(wrap_pyfunction!(get_password, m)?)?;
5252
m.add_function(wrap_pyfunction!(set_password, m)?)?;
5353
m.add_function(wrap_pyfunction!(delete_password, m)?)?;

0 commit comments

Comments
 (0)