Bump build projects to .NET10 (#4644)

internally it bump Nuke to 10.0.0

Author: Kielek

.config/dotnet-tools.json

@@ -3,7 +3,7 @@
   "isRoot": true,
   "tools": {
     "nuke.globaltool": {
-      "version": "9.0.4",
+      "version": "10.0.0",
       "commands": [
         "nuke"
       ]

build/Build.NuGet.Steps.cs

@@ -2,6 +2,9 @@
 using Extensions;
 using Nuke.Common;
 using Nuke.Common.IO;
+#if NET10_0
+using Nuke.Common.ProjectModel;
+#endif
 using Nuke.Common.Tools.DotNet;
 using Nuke.Common.Tools.NuGet;
 using Nuke.Common.Utilities.Collections;
@@ -125,7 +128,11 @@ partial class Build
             var nuspecSolutionFolder = Solution.GetSolutionFolder("nuget")
                 ?? throw new InvalidOperationException("Couldn't find the expected \"nuget\" solution folder.");
 
-            var nuspecProjects = nuspecSolutionFolder.Items.Keys.ToArray();
+#if NET9_0
+            throw new InvalidOperationException("NuSpec packaging requires .NET 10 or greater to run.");
+#else
+            var nuspecProjects = nuspecSolutionFolder.GetModel().Files!;
+
             foreach (var nuspecProject in nuspecProjects)
             {
                 NuGetTasks.NuGetPack(s => s
@@ -134,6 +141,8 @@ partial class Build
                     .SetProperties(nuspecCommonProperties)
                     .SetOutputDirectory(NuGetArtifactsDirectory));
             }
+#endif
+
         });
 
     Target BuildNuGetPackagesTests => _ => _

build/Directory.Packages.props

@@ -3,11 +3,15 @@
 
   <ItemGroup>
     <PackageVersion Include="Mono.Cecil" Version="0.11.6" />
-    <PackageVersion Include="Nuke.Common" Version="9.0.4" />
+    <PackageVersion Include="Nuke.Common" Version="10.0.0" />
+    <PackageVersion Include="Nuget.CommandLine" Version="7.0.0" />
+  </ItemGroup>
+  
+  <ItemGroup Condition=" '$(IsLegacyUbuntu)' != '' " >
+    <PackageVersion Update="Nuke.Common" Version="9.0.4" />
     <!-- Microsoft.Build is an indirect reference from Nuke.Common. Fixes https://github.com/advisories/GHSA-w3q9-fxm7-j8fq -->
     <PackageVersion Include="Microsoft.Build" Version="17.14.28" />
     <!-- Microsoft.Build.Tasks.Core is an indirect reference from Nuke.Common. Fixes https://github.com/advisories/GHSA-w3q9-fxm7-j8fq -->
     <PackageVersion Include="Microsoft.Build.Tasks.Core" Version="17.14.28" />
-    <PackageVersion Include="Nuget.CommandLine" Version="7.0.0" />
   </ItemGroup>
 </Project>

build/_build.csproj

@@ -2,7 +2,8 @@
 
   <PropertyGroup>
     <OutputType>Exe</OutputType>
-    <TargetFramework>net9.0</TargetFramework>
+    <TargetFramework Condition=" '$(IsLegacyUbuntu)' == '' " >net10.0</TargetFramework>
+    <TargetFramework Condition=" '$(IsLegacyUbuntu)' != '' " >net9.0</TargetFramework>
     <RootNamespace></RootNamespace>
     <NoWarn>CS0649;CS0169</NoWarn>
     <NukeRootDirectory>..\</NukeRootDirectory>
@@ -19,11 +20,13 @@
   <ItemGroup>
     <PackageReference Include="Mono.Cecil" />
     <PackageReference Include="Nuke.Common" />
+    <PackageReference Include="Nuget.CommandLine" ExcludeAssets="all" />
+  </ItemGroup>
+  <ItemGroup Condition=" '$(IsLegacyUbuntu)' != '' "  >
     <!-- Microsoft.Build is an indirect reference from Nuke.Common. Fixes https://github.com/advisories/GHSA-w3q9-fxm7-j8fq -->
     <PackageReference Include="Microsoft.Build" />
     <!-- Microsoft.Build.Tasks.Core is an indirect reference from Nuke.Common. Fixes https://github.com/advisories/GHSA-w3q9-fxm7-j8fq -->
     <PackageReference Include="Microsoft.Build.Tasks.Core" />
-    <PackageReference Include="Nuget.CommandLine" ExcludeAssets="all" />
   </ItemGroup>
   <ItemGroup>
     <PackageReference Include="DotNet.ReproducibleBuilds">

docker/ubuntu1604.dockerfile

@@ -37,4 +37,6 @@ RUN chmod +x ./dotnet-install.sh \
     && ./dotnet-install.sh -v 9.0.308 --install-dir /usr/share/dotnet --no-path \
     && rm dotnet-install.sh
 
+ENV IsLegacyUbuntu=true
+
 WORKDIR /project

test/OpenTelemetry.AutoInstrumentation.Tests/NetFrameworkDistroTests.cs

@@ -3,7 +3,7 @@
 
 // This test is defined in NET 9.0 because the tool is written in .NET 9.0
 // The actual test is testing .NET Framework context.
-#if NET9_0
+#if NET10_0
 
 using System.Reflection;
 using System.Runtime.InteropServices;

test/OpenTelemetry.AutoInstrumentation.Tests/OpenTelemetry.AutoInstrumentation.Tests.csproj

@@ -4,12 +4,12 @@
     <PackageReference Include="Newtonsoft.Json" />
     <PackageReference Include="Xunit.SkippableFact" />
     <PackageReference Include="log4net" />
-    <PackageReference Include="Microsoft.Build" Condition=" '$(TargetFramework)' == 'net9.0' " />
+    <PackageReference Include="Microsoft.Build" Condition=" '$(TargetFramework)' == 'net10.0' " />
   </ItemGroup>
 
   <ItemGroup>
     <ProjectReference Include="..\..\src\OpenTelemetry.AutoInstrumentation\OpenTelemetry.AutoInstrumentation.csproj" />
-    <ProjectReference Include="..\..\tools\DependencyListGenerator\DependencyListGenerator.csproj" Condition=" '$(TargetFramework)' == 'net9.0' " />
+    <ProjectReference Include="..\..\tools\DependencyListGenerator\DependencyListGenerator.csproj" Condition=" '$(TargetFramework)' == 'net10.0' " />
   </ItemGroup>
 
   <ItemGroup>

tools/DependencyListGenerator/DependencyListGenerator.csproj

@@ -1,7 +1,8 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <TargetFramework>net9.0</TargetFramework>
+    <TargetFramework Condition=" '$(IsLegacyUbuntu)' == '' " >net10.0</TargetFramework>
+    <TargetFramework Condition=" '$(IsLegacyUbuntu)' != '' " >net9.0</TargetFramework>
     <ImplicitUsings>enable</ImplicitUsings>
     <Nullable>disable</Nullable>
     <SignAssembly>true</SignAssembly>