CA1859

Author: Kielek

src/OpenTelemetry.AutoInstrumentation.StartupHook/RulesEngine/ApplicationInExcludeListRule.cs

@@ -65,7 +65,7 @@ private static string GetAppDomainName()
         }
     }
 
-    private static ICollection<string> GetExcludedApplicationNames()
+    private static List<string> GetExcludedApplicationNames()
     {
         var excludedProcesses = new List<string>();
 

src/OpenTelemetry.AutoInstrumentation/Logging/OtelLogging.cs

@@ -154,7 +154,7 @@ private static IOtelLogger CreateLogger(string suffix)
     private static ISink CreateSink(string suffix)
     {
         // Uses ISink? here, sink creation can fail so we specify default fallback at the end.
-        var sink = _configuredLogSink switch
+        ISink? sink = _configuredLogSink switch
         {
             LogSink.NoOp => NoopSink.Instance,
             LogSink.Console => new ConsoleSink(suffix),
@@ -168,7 +168,7 @@ private static ISink CreateSink(string suffix)
             NoopSink.Instance;
     }
 
-    private static ISink? CreateFileSink(string suffix)
+    private static PeriodicFlushToDiskSink? CreateFileSink(string suffix)
     {
         try
         {