Enable Roslyn analysis - SourceGenerator (#4661)

* SourceGenerator - enable analysis

* InvariantCulture fixes

* redundant using

* Fix CA2013

it reverts #2657 (comment)

* Collection initializer

* PR feedback - handle SA1118

Author: Kielek

src/SourceGenerators/EquatableArray.cs

@@ -20,7 +20,7 @@ public EquatableArray(T[] array)
 
     public bool Equals(EquatableArray<T> array)
     {
-        return object.ReferenceEquals(_array, array) || _array.AsSpan().SequenceEqual(array.AsSpan());
+        return _array.AsSpan().SequenceEqual(array.AsSpan());
     }
 
     public override int GetHashCode()

src/SourceGenerators/InstrumentationDefinitionsGenerator.cs

@@ -2,6 +2,7 @@
 // SPDX-License-Identifier: Apache-2.0
 
 using System.Collections.Immutable;
+using System.Globalization;
 using System.Text;
 using Microsoft.CodeAnalysis;
 using Microsoft.CodeAnalysis.CSharp.Syntax;
@@ -57,30 +58,30 @@ private static TargetToGenerate CreateTargetToGenerate(AttributeData attribute)
 
         var targetSignatureTypesBuilder = new StringBuilder();
 
-        targetSignatureTypesBuilder.AppendFormat("\"{0}\"", returnTypeName);
+        targetSignatureTypesBuilder.AppendFormat(CultureInfo.InvariantCulture, "\"{0}\"", returnTypeName);
 
         foreach (var parameterTypeName in parameterTypeNames)
         {
-            targetSignatureTypesBuilder.AppendFormat(", \"{0}\"", parameterTypeName.Value);
+            targetSignatureTypesBuilder.AppendFormat(CultureInfo.InvariantCulture, ", \"{0}\"", parameterTypeName.Value);
         }
 
-        var signalType = int.Parse(attribute.ConstructorArguments[8].Value!.ToString());
-        var integrationKind = int.Parse(attribute.ConstructorArguments[9].Value!.ToString());
+        var signalType = int.Parse(attribute.ConstructorArguments[8].Value!.ToString(), CultureInfo.InvariantCulture);
+        var integrationKind = int.Parse(attribute.ConstructorArguments[9].Value!.ToString(), CultureInfo.InvariantCulture);
         var integrationName = attribute.ConstructorArguments[7].Value!.ToString();
         var targetAssembly = attribute.ConstructorArguments[0].Value!.ToString();
         var targetType = attribute.ConstructorArguments[1].Value!.ToString();
         var targetMethod = attribute.ConstructorArguments[2].Value!.ToString();
 
         var minVersion = attribute.ConstructorArguments[5].Value?.ToString().Split('.')!;
 
-        var targetMinimumMajor = int.Parse(minVersion[0]);
-        var targetMinimumMinor = minVersion.Length > 1 && minVersion[1] != "*" ? int.Parse(minVersion[1]) : ushort.MinValue;
-        var targetMinimumPatch = minVersion.Length > 2 && minVersion[2] != "*" ? int.Parse(minVersion[2]) : ushort.MinValue;
+        var targetMinimumMajor = int.Parse(minVersion[0], CultureInfo.InvariantCulture);
+        var targetMinimumMinor = minVersion.Length > 1 && minVersion[1] != "*" ? int.Parse(minVersion[1], CultureInfo.InvariantCulture) : ushort.MinValue;
+        var targetMinimumPatch = minVersion.Length > 2 && minVersion[2] != "*" ? int.Parse(minVersion[2], CultureInfo.InvariantCulture) : ushort.MinValue;
 
         var maxVersion = attribute.ConstructorArguments[6].Value?.ToString().Split('.')!;
-        var targetMaximumMajor = int.Parse(maxVersion[0]);
-        var targetMaximumMinor = maxVersion.Length > 1 && maxVersion[1] != "*" ? int.Parse(maxVersion[1]) : ushort.MaxValue;
-        var targetMaximumPatch = maxVersion.Length > 2 && maxVersion[2] != "*" ? int.Parse(maxVersion[2]) : ushort.MaxValue;
+        var targetMaximumMajor = int.Parse(maxVersion[0], CultureInfo.InvariantCulture);
+        var targetMaximumMinor = maxVersion.Length > 1 && maxVersion[1] != "*" ? int.Parse(maxVersion[1], CultureInfo.InvariantCulture) : ushort.MaxValue;
+        var targetMaximumPatch = maxVersion.Length > 2 && maxVersion[2] != "*" ? int.Parse(maxVersion[2], CultureInfo.InvariantCulture) : ushort.MaxValue;
 
         return new TargetToGenerate(signalType, integrationName, targetAssembly, targetType, targetMethod, targetMinimumMajor, targetMinimumMinor, targetMinimumPatch, targetMaximumMajor, targetMaximumMinor, targetMaximumPatch, targetSignatureTypesBuilder.ToString(), integrationKind);
     }
@@ -122,10 +123,7 @@ private static string GenerateInstrumentationDefinitionsPartialClass(
                 {
                     byName.Add(
                         targetToGenerate.IntegrationName,
-                        new List<(string IntegrationType, TargetToGenerate Target)>
-                        {
-                            (integrationToGenerate.Value.IntegrationType, targetToGenerate)
-                        });
+                        [(integrationToGenerate.Value.IntegrationType, targetToGenerate)]);
                 }
 
                 instrumentationCount++;
@@ -134,9 +132,7 @@ private static string GenerateInstrumentationDefinitionsPartialClass(
 
         var generatedMethodName = integrationKind == IntegrationKindDirect ? "GetDefinitionsArray" : "GetDerivedDefinitionsArray";
 
-        var sb = new StringBuilder()
-            .AppendFormat(
-                @"//------------------------------------------------------------------------------
+        const string headerTemplate = @"//------------------------------------------------------------------------------
 // <auto-generated>
 //     This code was generated by the InstrumentationDefinitionsGenerator tool. To safely
 //     modify this file, edit InstrumentMethodAttribute on the classes and
@@ -155,9 +151,9 @@ internal static partial class InstrumentationDefinitions
 {{
     private static NativeCallTargetDefinition[] {0}()
     {{
-        var nativeCallTargetDefinitions = new List<NativeCallTargetDefinition>({1});",
-                generatedMethodName,
-                instrumentationCount)
+        var nativeCallTargetDefinitions = new List<NativeCallTargetDefinition>({1});";
+        var sb = new StringBuilder()
+            .AppendFormat(CultureInfo.InvariantCulture, headerTemplate, generatedMethodName, instrumentationCount)
             .AppendLine();
 
         const string tracesHeader = @"        // Traces
@@ -211,16 +207,15 @@ private static void GenerateIntegrations(Dictionary<string, List<(string Integra
 
             sb.Append("            // ");
             sb.AppendLine(group.Key);
-            sb.AppendFormat(
-                @"            if ({0}.{1}))
-            {{",
-                conditionPrefix,
-                group.Key);
+            const string ifTemplate = @"            if ({0}.{1}))
+            {{";
+            sb.AppendFormat(CultureInfo.InvariantCulture, ifTemplate, conditionPrefix, group.Key);
             sb.AppendLine();
 
             foreach (var integration in group.Value)
             {
                 sb.AppendFormat(
+                    CultureInfo.InvariantCulture,
                     "                nativeCallTargetDefinitions.Add(new(\"{0}\", \"{1}\", \"{2}\", [{3}], {4}, {5}, {6}, {7}, {8}, {9}, AssemblyFullName, \"{10}\"));",
                     integration.Target.Assembly,
                     integration.Target.Type,

src/SourceGenerators/IntegrationToGenerate.cs

@@ -1,8 +1,6 @@
 // Copyright The OpenTelemetry Authors
 // SPDX-License-Identifier: Apache-2.0
 
-using System.Collections.Immutable;
-
 namespace SourceGenerators;
 
 internal readonly record struct IntegrationToGenerate(string IntegrationType, EquatableArray<TargetToGenerate> Targets)

src/SourceGenerators/SourceGenerators.csproj

@@ -5,6 +5,7 @@
     <EnablePublicApi>false</EnablePublicApi>
     <EnforceExtendedAnalyzerRules>true</EnforceExtendedAnalyzerRules>
     <IsRoslynComponent>true</IsRoslynComponent>
+    <AnalysisLevel>latest-All</AnalysisLevel>
   </PropertyGroup>
 
   <ItemGroup>