Tools/SdkVersionAnalyzer - enable analysis

Kielek · Kielek · commit e6631355df9c · 2025-12-03T09:17:51.000+01:00
diff --git a/tools/SdkVersionAnalyzer/ActionWorkflowAnalyzer.cs b/tools/SdkVersionAnalyzer/ActionWorkflowAnalyzer.cs
@@ -132,7 +132,7 @@ private static IEnumerable<DotnetSdkVersion> ExtractDotnetSdkVersions(string con
             foreach (var step in (YamlSequenceNode)stepsNode)
             {
                 var jobStepNode = (YamlMappingNode)step;
-                if (jobStepNode.Children.TryGetValue(new YamlScalarNode("uses"), out var usesNode) && usesNode.ToString().StartsWith("actions/setup-dotnet"))
+                if (jobStepNode.Children.TryGetValue(new YamlScalarNode("uses"), out var usesNode) && usesNode.ToString().StartsWith("actions/setup-dotnet", StringComparison.Ordinal))
                 {
                     var withNode = (YamlMappingNode)jobStepNode.Children[new YamlScalarNode("with")];
                     var dotnetVersionNode = (YamlScalarNode)withNode.Children[new YamlScalarNode("dotnet-version")];
diff --git a/tools/SdkVersionAnalyzer/DockerfileAnalyzer.cs b/tools/SdkVersionAnalyzer/DockerfileAnalyzer.cs
@@ -168,6 +168,6 @@ private static string[] GetDockerfiles(string root)
 
     private static RunInstruction? GetDotnetInstallingInstruction(Dockerfile dockerfile)
     {
-        return dockerfile.Items.OfType<RunInstruction>().SingleOrDefault(i => i.ToString().Contains("./dotnet-install.sh"));
+        return dockerfile.Items.OfType<RunInstruction>().SingleOrDefault(i => i.ToString().Contains("./dotnet-install.sh", StringComparison.Ordinal));
     }
 }
diff --git a/tools/SdkVersionAnalyzer/DotnetSdkVersion.cs b/tools/SdkVersionAnalyzer/DotnetSdkVersion.cs
@@ -3,4 +3,4 @@
 
 namespace SdkVersionAnalyzer;
 
-internal record DotnetSdkVersion(string? Net8SdkVersion, string? Net9SdkVersion, string? Net10SdkVersion);
+internal sealed record DotnetSdkVersion(string? Net8SdkVersion, string? Net9SdkVersion, string? Net10SdkVersion);
diff --git a/tools/SdkVersionAnalyzer/SdkVersionAnalyzer.csproj b/tools/SdkVersionAnalyzer/SdkVersionAnalyzer.csproj
@@ -1,15 +1,18 @@
 ﻿<Project Sdk="Microsoft.NET.Sdk">
 
-    <PropertyGroup>
-        <TargetFramework>net10.0</TargetFramework>
-        <ImplicitUsings>enable</ImplicitUsings>
-        <Nullable>enable</Nullable>
-        <OutputType>Exe</OutputType>
-    </PropertyGroup>
+  <PropertyGroup>
+    <TargetFramework>net10.0</TargetFramework>
+    <ImplicitUsings>enable</ImplicitUsings>
+    <Nullable>enable</Nullable>
+    <OutputType>Exe</OutputType>
+    <!-- CA1303 Do not pass literals as localized parameters. It is internal tool, so no need to localize Console messages. -->
+    <NoWarn>$(NoWarn);CA1303</NoWarn>
+    <AnalysisLevel>latest-All</AnalysisLevel>
+  </PropertyGroup>
 
-    <ItemGroup>
-      <PackageReference Include="Valleysoft.DockerfileModel" />
-      <PackageReference Include="YamlDotNet" />
-    </ItemGroup>
+  <ItemGroup>
+    <PackageReference Include="Valleysoft.DockerfileModel" />
+    <PackageReference Include="YamlDotNet" />
+  </ItemGroup>
 
-</Project>
+</Project>
diff --git a/tools/SdkVersionAnalyzer/VersionComparer.cs b/tools/SdkVersionAnalyzer/VersionComparer.cs
@@ -33,7 +33,7 @@ public static bool IsNet9Version(string versionString)
 
     public static bool IsNet10Version(string versionString)
     {
-        return versionString.StartsWith("10");
+        return versionString.StartsWith("10", StringComparison.Ordinal);
     }
 
     private static bool CompareVersion(string expectedVersion, string? extractedVersion)

Original file line number	Diff line number	Diff line change
`@@ -132,7 +132,7 @@ private static IEnumerable<DotnetSdkVersion> ExtractDotnetSdkVersions(string con`
`132`	`132`	`foreach (var step in (YamlSequenceNode)stepsNode)`
`133`	`133`	`{`
`134`	`134`	`var jobStepNode = (YamlMappingNode)step;`
`135`		`- if (jobStepNode.Children.TryGetValue(new YamlScalarNode("uses"), out var usesNode) && usesNode.ToString().StartsWith("actions/setup-dotnet"))`
	`135`	`+ if (jobStepNode.Children.TryGetValue(new YamlScalarNode("uses"), out var usesNode) && usesNode.ToString().StartsWith("actions/setup-dotnet", StringComparison.Ordinal))`
`136`	`136`	`{`
`137`	`137`	`var withNode = (YamlMappingNode)jobStepNode.Children[new YamlScalarNode("with")];`
`138`	`138`	`var dotnetVersionNode = (YamlScalarNode)withNode.Children[new YamlScalarNode("dotnet-version")];`
Original file line number	Diff line number	Diff line change
`@@ -168,6 +168,6 @@ private static string[] GetDockerfiles(string root)`
`168`	`168`
`169`	`169`	`private static RunInstruction? GetDotnetInstallingInstruction(Dockerfile dockerfile)`
`170`	`170`	`{`
`171`		`- return dockerfile.Items.OfType<RunInstruction>().SingleOrDefault(i => i.ToString().Contains("./dotnet-install.sh"));`
	`171`	`+ return dockerfile.Items.OfType<RunInstruction>().SingleOrDefault(i => i.ToString().Contains("./dotnet-install.sh", StringComparison.Ordinal));`
`172`	`172`	`}`
`173`	`173`	`}`
Original file line number	Diff line number	Diff line change
`@@ -3,4 +3,4 @@`
`3`	`3`
`4`	`4`	`namespace SdkVersionAnalyzer;`
`5`	`5`
`6`		`-internal record DotnetSdkVersion(string? Net8SdkVersion, string? Net9SdkVersion, string? Net10SdkVersion);`
	`6`	`+internal sealed record DotnetSdkVersion(string? Net8SdkVersion, string? Net9SdkVersion, string? Net10SdkVersion);`
Original file line number	Diff line number	Diff line change
`@@ -33,7 +33,7 @@ public static bool IsNet9Version(string versionString)`
`33`	`33`
`34`	`34`	`public static bool IsNet10Version(string versionString)`
`35`	`35`	`{`
`36`		`- return versionString.StartsWith("10");`
	`36`	`+ return versionString.StartsWith("10", StringComparison.Ordinal);`
`37`	`37`	`}`
`38`	`38`
`39`	`39`	`private static bool CompareVersion(string expectedVersion, string? extractedVersion)`