Skip to content

Conversation

@bmwalters
Copy link

@bmwalters bmwalters commented Nov 21, 2025

Description

Adds instrumentation for database commit() and rollback() transaction operations across all DB-API instrumentations.

Type of change

  • New feature (non-breaking change which adds functionality)

Changes

  • Added commit() and rollback() span instrumentation to dbapi module
  • Added enable_transaction_spans configuration flag (default: True)
  • Created AsyncTracedConnectionProxy for async connections (psycopg)
  • Plumbed configuration through all dependent instrumentors: pymysql, mysql, mysqlclient, psycopg, psycopg2, sqlite3, pymssql

How Has This Been Tested?

  • Added unit tests for sync commit/rollback in test_dbapi_integration.py
  • Added unit tests for sync and async commit/rollback in test_psycopg_integration.py
  • Added functional tests for pymysql in test_pymysql_functional.py
  • All existing tests pass

Does This PR Require a Core Repo Change?

  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@bmwalters bmwalters requested a review from a team as a code owner November 21, 2025 07:48
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 21, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: bmwalters / name: Bradley Walters (a2e9819)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Ready for review

Development

Successfully merging this pull request may close these issues.

1 participant