Skip to content

Commit 7cef070

Browse files
Fix the type hint of _metrics_data within InMemoryMetricReader (#4837)
* Fix the type hint of _metrics_data within InMemoryMetricReader This gets initialized to None, so the type hint should be MetricsData | None * Add CHANGELOG entry * Update CHANGELOG.md --------- Co-authored-by: Riccardo Magliocchetti <[email protected]>
1 parent 8101abd commit 7cef070

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
1212

1313
## Unreleased
1414

15+
- `opentelemetry-sdk`: Fix the type hint of the `_metrics_data` property to allow `None`
16+
([#4837](https://github.com/open-telemetry/opentelemetry-python/pull/4837)
1517
- Regenerate opentelemetry-proto code with v1.9.0 release
1618
([#4840](https://github.com/open-telemetry/opentelemetry-python/pull/4840))
1719
- Add python 3.14 support

opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/export/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -406,7 +406,7 @@ def __init__(
406406
preferred_aggregation=preferred_aggregation,
407407
)
408408
self._lock = RLock()
409-
self._metrics_data: MetricsData = None
409+
self._metrics_data: MetricsData | None = None
410410

411411
def get_metrics_data(
412412
self,

0 commit comments

Comments
 (0)