Skip to content

Commit 2e4af3c

Browse files
author
Liudmila Molkova
authored
Remove mentions of build-tools semconvgen (#2279)
1 parent 92ffed6 commit 2e4af3c

File tree

11 files changed

+15
-16
lines changed

11 files changed

+15
-16
lines changed

docs/non-normative/code-generation.md

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -81,9 +81,7 @@ This section contains suggestions on how to structure semantic convention artifa
8181
This section describes how to do code-generation with weaver.
8282

8383
> [!IMPORTANT]
84-
> We're transitioning away from [build-tools](https://github.com/open-telemetry/build-tools/blob/main/semantic-conventions/README.md#code-generator)
85-
> to [opentelemetry-weaver](https://github.com/open-telemetry/weaver/blob/main/crates/weaver_forge/README.md) to generate code for semantic conventions.
86-
> All new code-generation should be done using weaver, build-tools may become incompatible with future version of semantic conventions.
84+
> All code-generation should be done using [weaver](https://github.com/open-telemetry/weaver/blob/main/crates/weaver_forge/README.md),
8785
> Weaver supports Semantic Conventions version starting from [1.26.0](https://github.com/open-telemetry/semantic-conventions/tree/v1.26.0).
8886
8987
Code-generation is based on YAML definitions in the specific version of semantic conventions.
@@ -105,7 +103,8 @@ Check out [weaver code-generation documentation for more details](https://github
105103

106104
### Migrating from build-tools
107105

108-
Migration from build-tools involves changing Jinja templates and adding a [weaver config file](https://github.com/open-telemetry/weaver/blob/main/crates/weaver_forge/README.md#configuration-file---weaveryaml).
106+
Migration from [build-tools](https://github.com/open-telemetry/build-tools/blob/v0.25.0/semantic-conventions/README.md)
107+
involves changing Jinja templates and adding a [weaver config file](https://github.com/open-telemetry/weaver/blob/main/crates/weaver_forge/README.md#configuration-file---weaveryaml).
109108

110109
#### Weaver config
111110

model/azure/cosmosdb-metrics.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ groups:
2525
unit: "{instance}"
2626
stability: development
2727
attributes:
28-
# TODO: add db.system.name once https://github.com/open-telemetry/build-tools/issues/192 is possible
28+
# TODO: add db.system.name once https://github.com/open-telemetry/weaver/issues/479 is possible
2929
# - ref: db.system.name
3030
# requirement_level:
3131
# conditionally_required: if available

model/cpu/registry.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ groups:
77
- id: cpu.mode
88
brief: "The mode of the CPU"
99
type:
10-
# TODO: Fix how enum members are used in semantic conventions after https://github.com/open-telemetry/build-tools/issues/192 is merged
10+
# TODO: Fix how enum members are used in semantic conventions after https://github.com/open-telemetry/weaver/issues/479
1111
members:
1212
- id: user
1313
value: 'user'

model/database/common.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ groups:
3131
stability: development
3232
extends: attributes.db.client.minimal
3333
attributes:
34-
# TODO: add db.system.name once https://github.com/open-telemetry/build-tools/issues/192 is possible
34+
# TODO: add db.system.name once https://github.com/open-telemetry/weaver/issues/479 is possible
3535
# - ref: db.system.name
3636
# requirement_level:
3737
# conditionally_required: if available

model/database/metrics.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ groups:
1111
extends: attributes.db.client.with_query_and_collection
1212
attributes:
1313
- ref: db.system.name
14-
# TODO: Not adding to the minimal because of https://github.com/open-telemetry/build-tools/issues/192
14+
# TODO: Not adding to the minimal because of https://github.com/open-telemetry/weaver/issues/479
1515
requirement_level: required
1616
- ref: db.stored_procedure.name
1717
requirement_level:
@@ -145,7 +145,7 @@ groups:
145145
extends: attributes.db.client.with_query_and_collection
146146
attributes:
147147
- ref: db.system.name
148-
# TODO: Not adding to the minimal because of https://github.com/open-telemetry/build-tools/issues/192
148+
# TODO: Not adding to the minimal because of https://github.com/open-telemetry/weaver/issues/479
149149
requirement_level: required
150150
- ref: network.peer.address
151151
brief: Peer address of the database node where the operation was performed.

model/database/spans.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ groups:
44
type: attribute_group
55
brief: This group defines the attributes used to perform database client calls.
66
attributes:
7-
# TODO: add db.system.name once https://github.com/open-telemetry/build-tools/issues/192 is possible
7+
# TODO: add db.system.name once https://github.com/open-telemetry/weaver/issues/479 is possible
88
# - ref: db.system.name
99
# sampling_relevant: true
1010
- ref: db.operation.name
@@ -96,7 +96,7 @@ groups:
9696
recommended: if and only if `network.peer.address` is set.
9797
- ref: db.system.name
9898
sampling_relevant: true
99-
# TODO: Not adding to the minimal because of https://github.com/open-telemetry/build-tools/issues/192
99+
# TODO: Not adding to the minimal because of https://github.com/open-telemetry/weaver/issues/479
100100
requirement_level: required
101101
- ref: db.namespace
102102
sampling_relevant: true

model/feature-flags/events.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ groups:
3737
examples: ["provider_not_ready", "targeting_key_missing", "provider_fatal", "general"]
3838
requirement_level:
3939
conditionally_required: If and only if an error occurred during flag evaluation.
40-
# TODO: move note to yaml once https://github.com/open-telemetry/build-tools/issues/192 is supported
40+
# TODO: move note to yaml once https://github.com/open-telemetry/weaver/issues/479 is supported
4141
note: |
4242
If one of these values applies, then it MUST be used; otherwise, a custom value MAY be used.
4343

model/gen-ai/spans.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ groups:
108108
extends: attributes.gen_ai.inference.client
109109
attributes:
110110
- ref: gen_ai.system
111-
# TODO: Not adding to common attributes because of https://github.com/open-telemetry/build-tools/issues/192
111+
# TODO: Not adding to common attributes because of https://github.com/open-telemetry/weaver/issues/479
112112
requirement_level: required
113113
- ref: gen_ai.request.top_k
114114
requirement_level: recommended

model/kestrel/metrics.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ groups:
4444
requirement_level:
4545
conditionally_required: if and only if an error has occurred.
4646
examples: ['connection_reset', 'invalid_handshake']
47-
# TODO: move note to yaml once https://github.com/open-telemetry/build-tools/issues/192 is supported
47+
# TODO: move note to yaml once https://github.com/open-telemetry/weaver/issues/479 is supported
4848
note: |
4949
Starting from .NET 9, Kestrel `kestrel.connection.duration` metric reports
5050
the following errors types when a corresponding error occurs:

model/messaging/common.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ groups:
44
brief: "Common cross-signal messaging attributes."
55
stability: development
66
attributes:
7-
# TODO: Not adding `messaging.system` to the minimal because of https://github.com/open-telemetry/build-tools/issues/192
7+
# TODO: Not adding `messaging.system` to the minimal because of https://github.com/open-telemetry/weaver/issues/479
88
- ref: error.type
99
examples: ["amqp:decode-error", "KAFKA_STORAGE_ERROR", "channel-error"]
1010
requirement_level:

0 commit comments

Comments
 (0)