feedback

Change-Id: I63f11ca8081f71b55b793ec88f35ef64bbace8e6
Co-developed-by: Cursor <[email protected]>

Author: Cirilla-zmh

docs/gen-ai/gen-ai-tool-definitions.json

@@ -2,6 +2,7 @@
     "$defs": {
         "ToolDefinition": {
             "additionalProperties": true,
+            "description": "Represents a tool definition.",
             "properties": {
                 "type": {
                     "anyOf": [
@@ -13,7 +14,7 @@
                         }
                     ],
                     "description": "Type of the tool.",
-                    "title": "ToolType"
+                    "title": "Type"
                 },
                 "name": {
                     "description": "Name of the tool.",
@@ -26,17 +27,20 @@
                     "type": "string"
                 },
                 "parameters": {
-                    "description": "Format of the tool parameters. Maybe it is a JSON schema.",
+                    "default": null,
+                    "description": "Schema that defines the parameters accepted by the tool. The RECOMMENDED format is JSON Schema.",
                     "title": "Parameters"
                 },
                 "response": {
-                    "description": "Format of the tool response. Maybe it is a JSON schema.",
+                    "default": null,
+                    "description": "Schema that defines the response returned by the tool. The RECOMMENDED format is JSON Schema.",
                     "title": "Response"
                 }
             },
             "required": [
                 "type",
-                "name"
+                "name",
+                "description"
             ],
             "title": "ToolDefinition",
             "type": "object"
@@ -50,7 +54,7 @@
             "type": "string"
         }
     },
-    "description": "Represents the list of tool definitions sent to the model.",
+    "description": "Represents the list of tool definitions available to the GenAI agent or model.",
     "items": {
         "$ref": "#/$defs/ToolDefinition"
     },

docs/gen-ai/non-normative/examples-llm-calls.md

@@ -248,6 +248,18 @@ They are likely to be siblings if there is an encompassing span.
 | `gen_ai.usage.output_tokens`    | `17`                                        |
 | `gen_ai.usage.input_tokens`     | `47`                                        |
 | `gen_ai.response.finish_reasons`| `["tool_calls"]`                            |
+| `gen_ai.tool.definitions`       | [`gen_ai.tool.definitions`](#gen-ai-tool-definitions-tool-call-span-0) |
+
+<span id="gen-ai-tool-definitions-tool-call-span-0">`gen_ai.tool.definitions` value</span>
+
+```json
+[
+  {
+    "type": "function",
+    "name": "get_weather"
+  }
+]
+```
 
 **Tool call:**
 

docs/gen-ai/non-normative/models.ipynb

@@ -68,7 +68,7 @@
     "    type: Literal[\"tool_call\"] = Field(description=\"The type of the content captured in this part.\")\n",
     "    id: Optional[str] = Field(default=None, description=\"Unique identifier for the tool call.\")\n",
     "    name: str = Field(description=\"Name of the tool.\")\n",
-    "    arguments: Any = Field(None, description=\"Arguments for the tool call.\")\n",
+    "    arguments: Any = Field(deafult=None, description=\"Arguments for the tool call.\")\n",
     "\n",
     "    class Config:\n",
     "        extra = \"allow\"\n",
@@ -139,42 +139,6 @@
    "metadata": {},
    "outputs": [],
    "source": [
-    "class ToolType(str, Enum):\n",
-    "    FUNCTION = \"function\"\n",
-    "    CUSTOM = \"custom\"\n",
-    "\n",
-    "class JSONSchema(BaseModel):\n",
-    "    \"\"\"\n",
-    "    Represents a JSON schema to define the format of the tool parameters or response.\n",
-    "    \"\"\"\n",
-    "    type: str = Field(description=\"Type of the overall data.\")\n",
-    "\n",
-    "    class Config:\n",
-    "        extra = \"allow\"\n",
-    "\n",
-    "class ToolDefinition(BaseModel):\n",
-    "    \"\"\"\n",
-    "    Represents a tool definition.\n",
-    "    \"\"\"\n",
-    "    type: Union[ToolType, str] = Field(description=\"Type of the tool.\")\n",
-    "    name: str = Field(description=\"Name of the tool.\")\n",
-    "    description: str = Field(description=\"Description of the tool.\")\n",
-    "    parameters: Optional[Union[JSONSchema, Any]] = Field(\n",
-    "        description=(\n",
-    "            \"Format of the tool parameters the function expects. \"\n",
-    "            \"The RECOMMENDED data type is JSON Schema. \"\n",
-    "        )\n",
-    "    )\n",
-    "    response: Optional[Union[JSONSchema, Any]] = Field(\n",
-    "        description=(\n",
-    "            \"Format of the tool response the function returns. \"\n",
-    "            \"The RECOMMENDED data type is JSON Schema. \"\n",
-    "        )\n",
-    "    )\n",
-    "\n",
-    "    class Config:\n",
-    "        extra = \"allow\"\n",
-    "\n",
     "class InputMessages(RootModel[List[ChatMessage]]):\n",
     "    \"\"\"\n",
     "    Represents the list of input messages sent to the model.\n",
@@ -277,6 +241,35 @@
    "metadata": {},
    "outputs": [],
    "source": [
+    "class ToolType(str, Enum):\n",
+    "    FUNCTION = \"function\"\n",
+    "    CUSTOM = \"custom\"\n",
+    "\n",
+    "class ToolDefinition(BaseModel):\n",
+    "    \"\"\"\n",
+    "    Represents a tool definition.\n",
+    "    \"\"\"\n",
+    "    type: Union[ToolType, str] = Field(description=\"Type of the tool.\")\n",
+    "    name: str = Field(description=\"Name of the tool.\")\n",
+    "    description: str = Field(description=\"Description of the tool.\")\n",
+    "    parameters: Any = Field(\n",
+    "        default=None,\n",
+    "        description=(\n",
+    "            \"Schema that defines the parameters accepted by the tool. \"\n",
+    "            \"The RECOMMENDED format is JSON Schema.\"\n",
+    "        )\n",
+    "    )\n",
+    "    response: Any = Field(\n",
+    "        default=None,\n",
+    "        description=(\n",
+    "            \"Schema that defines the response returned by the tool. \"\n",
+    "            \"The RECOMMENDED format is JSON Schema.\"\n",
+    "        )\n",
+    "    )\n",
+    "\n",
+    "    class Config:\n",
+    "        extra = \"allow\"\n",
+    "\n",
     "class ToolDefinitions(RootModel[List[ToolDefinition]]):\n",
     "    \"\"\"\n",
     "    Represents the list of tool definitions available to the GenAI agent or model.\n",
@@ -290,7 +283,7 @@
  ],
  "metadata": {
   "kernelspec": {
-   "display_name": "Python 3",
+   "display_name": "semconv",
    "language": "python",
    "name": "python3"
   },
@@ -304,7 +297,7 @@
    "name": "python",
    "nbconvert_exporter": "python",
    "pygments_lexer": "ipython3",
-   "version": "3.13.5"
+   "version": "3.13.7"
   }
  },
  "nbformat": 4,