-
Notifications
You must be signed in to change notification settings - Fork 56
Description
Is your feature request related to a problem? Please describe.
Weaver lacks any ability to define profiles
Describe the solution you'd like
We should be able to define profile telemetry using yaml.
Based on the proto I forsee the following definitions as being need.
the profile definition should contain:
period_kind: string ie heapperiod_unit: string ie bytesattributes: attribute ref arraysample: sample ref
The sample definition should contain:
sample_kind: string ie allocated_spacesample_unit: string ie bytesattributes: attribute ref array
Which when resolved creates the following definition:
period_kind: string ie heapperiod_unit: string ie bytessample_type: stringsample_kind: string ie allocated_spacesample_unit: string ie bytesattributes: attribute array with thecapture.levelproperty distinguishing if it issampleorprofileattribute as per Instrumentation scopes #1005
Describe alternatives you've considered
Not defining profiles.
Directly defining profiles in their resolved form ie no seperate samples but samples couldn't be re-used.
Additional context
Should be considered in context of v2 to ensure it is designed to support it.
Tip: React with 👍 to help prioritize this issue. Please use comments to provide useful context, avoiding +1 or me too, to help us triage it. Learn more here.
Metadata
Metadata
Assignees
Labels
Type
Projects
Status