Skip to content

Commit 0fc75ea

Browse files
committed
fix/issue#18891
1 parent e256657 commit 0fc75ea

File tree

1 file changed

+11
-1
lines changed

1 file changed

+11
-1
lines changed

src/api/app/controllers/build_controller.rb

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,17 @@ def logfile
143143

144144
def result
145145
# this route is mainly for checking submissions to a target project
146-
return result_lastsuccess if params.key?(:lastsuccess)
146+
# allowed value are set to true/false or 1/0
147+
if params.key?(:lastsuccess)
148+
allowed_values = ["1", "0", "true", "false", 1, 0 , true, false]
149+
150+
unless allowed_values.include(params[:lastsuccess])
151+
return render_error status:400,
152+
errorcode: "invalid_lastsuccess_value",
153+
message: "Parameter 'lastsuccess' must be true/false or 1/0"
154+
end
155+
return result_lastsuccess
156+
end
147157

148158
# for permission check
149159
Project.get_by_name(params[:project])

0 commit comments

Comments
 (0)