Fix: Validate lastsuccess query param in BuildController #18913
+41
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@rubhanazeem Please review my changes , should i also add test cases for this ? |
piyusshkumar
force-pushed
the
restricting-queryparams
branch
2 times, most recently
from
450d659 to
0fc75ea
Compare
piyusshkumar
force-pushed
the
restricting-queryparams
branch
from
eb3c761 to
d6aca85
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr fixes #18891 where the API accepted any value for the latestsuccess query parameter in:
/build/{project}/_result?lastsuccess=1
Previously, the controller only checked for the presence of lastsuccess, without validating it. This update restricts the parameter to valid boolean values only: true/false or 1/0
Any other string or number will now return 400 Bad Request with a clear error message.