Fix shadowed err on request config execute method #570
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The current implementation when calling
RequestConfig.Executewill eventually call thehandlerwhich downstream calls theDomethod on the httpClient.This is called multiple times as we loop over the retries. In this below case, we will shadow the err. This can causes issues as we are shadowing the err from the handler.
This PR introduces a
var connErr errorwhich is set on each call of a retry. At the end, if there is an issue, we return theconnErr